[Bug 1360365] New: Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Bug ID: 1360365
           Summary: Review Request: python-pytest-mock - Thin-wrapper
                    around the mock package for easier use with py.test
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://dl.jujens.eu/SPECS/python-pytest-mock.spec
SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-mock-1.1-1.fc24.src.rpm

Description:
his plugin installs a mocker fixture which is a thin-wrapper around the
patching API provided by the mock package, but with the benefit of not having
to worry about undoing patches at the end of a test.

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
%{sum} macro is not necessary, you can write Summary: normally first time, and
then use Summary: %{summary} for the subsequent ones.

You don't need to actually delete .egg-info.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ standard python packaging is used
+ python_provide is used
+ no scriptlets present or necessary
- builds and installs OK
? P/R/BR look OK

%check fails in mock, looks like you need BR's on mock too.

----------------------------- Captured stderr call
-----------------------------
nomatch: '*"mock" fixture has been deprecated*'
    and: u''
________________________ test_mocker_aliases[MagicMock]
________________________
name = 'MagicMock'
    @pytest.mark.parametrize('name', ['MagicMock', 'PropertyMock', 'Mock',
'call', 'ANY'])
    def test_mocker_aliases(name):
>   from pytest_mock import mock_module, MockFixture

test_pytest_mock.py:137: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
    import inspect
    import sys

import pytest

if sys.version_info >= (3, 3): # pragma: no cover
        import unittest.mock as mock_module
    else:
>   import mock as mock_module

E       ImportError: No module named mock
pytest_mock.py:9: ImportError

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #2 from Julien Enselme  ---
Sorry for the delay:

* Mon Aug 29 2016 Julien Enselme  - 1.1-2
- Add python2-mock to BR so %%check passes correctly.

SRPM: http://dl.jujens.eu/SRPMS/python-pytest-mock-1.1-2.fc24.src.rpm
SPEC: http://dl.jujens.eu/SPECS/python-pytest-mock.spec
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15424875

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
> %{sum} macro is not necessary, you can write Summary: normally first time, and then use Summary: %{summary} for the subsequent ones.
> You don't need to actually delete .egg-info.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ standard python packaging is used
+ python_provide is used
+ no scriptlets present or necessary
+ builds and installs OK
+ P/R/BR look OK

Package is APPROVED.

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #4 from Julien Enselme  ---
Thanks for the review!

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-mock

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #6 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2018bc3322

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #7 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6b9375ced

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #8 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2018bc3322

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #9 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6b9375ced

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #10 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-09-05 13:52:54

[Bug 1360365] Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360365

--- Comment #11 from Fedora Update System  ---
python-pytest-mock-1.1-3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.