https://bugzilla.redhat.com/show_bug.cgi?id=2284159
Bug ID: 2284159 Summary: Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathan@almalinux.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/cen... SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/cen...
Description: An unofficial GUI wrapper around the Tailscale CLI client. Fedora Account System Username: jonathanspw
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Status|NEW |ASSIGNED CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
Release: 1
Missing DistTag.
%if %{with vendor} # see create-vendor-tarball.sh in this distgit repo Source0: trayscale-%{version}-vendored.tar.xz %else Source0: %{gosource} %endif
The script needs to be included as a source so that it's part of the SRPM.
desktop-file-validate %{buildroot}%{_datadir}/applications/dev.deedles.Trayscale.desktop appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/dev.deedles.Trayscale.metainfo.xml
This should be in %check
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
--- Comment #3 from Jonathan Wright jonathan@almalinux.org --- Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
--- Comment #4 from Neal Gompa ngompa13@gmail.com ---
%if %{with vendor} # see create-vendor-tarball.sh in this distgit repo Source0: trayscale-%{version}-vendored.tar.xz Source1: create-vendor-tarball.sh %else Source0: %{gosource} %endif
Sources are not allowed to be conditionalized. You should probably just use the vendored sources and have a conditional in prep to strip bundled deps when not being used.
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
--- Comment #5 from Jonathan Wright jonathan@almalinux.org --- Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7623146 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Package was generated through go2rpm, simplifying the review considerably.
- Conforms to packaging guidelines (go2rpm generated spec) - license correct and valid - builds and installs
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/trayscale
https://bugzilla.redhat.com/show_bug.cgi?id=2284159
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2024-07-19 02:14:10
package-review@lists.fedoraproject.org