[Bug 2284159] New: Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Bug ID: 2284159
           Summary: Review Request: trayscale - Unofficial GUI wrapper
                    around the Tailscale CLI client
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/cen...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/cen...

Description: An unofficial GUI wrapper around the Tailscale CLI client.
Fedora Account System Username: jonathanspw

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

--- Comment #2 from Neal Gompa  ---
Initial spec review:
> Release:        1

Missing DistTag.
> %if %{with vendor}
> # see create-vendor-tarball.sh in this distgit repo
> Source0:        trayscale-%{version}-vendored.tar.xz
> %else
> Source0:        %{gosource}
> %endif

The script needs to be included as a source so that it's part of the SRPM.
> desktop-file-validate %{buildroot}%{_datadir}/applications/dev.deedles.Trayscale.desktop
> appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/dev.deedles.Trayscale.metainfo.xml

This should be in %check

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

--- Comment #3 from Jonathan Wright  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

--- Comment #4 from Neal Gompa  ---
> %if %{with vendor}
> # see create-vendor-tarball.sh in this distgit repo
> Source0:        trayscale-%{version}-vendored.tar.xz
> Source1:        create-vendor-tarball.sh
> %else
> Source0:        %{gosource}
> %endif

Sources are not allowed to be conditionalized. You should probably just use the
vendored sources and have a conditional in prep to strip bundled deps when not
being used.

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

--- Comment #5 from Jonathan Wright  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fed...

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7623146
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #7 from Neal Gompa  ---
Package was generated through go2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (go2rpm generated spec)
- license correct and valid
- builds and installs

PACKAGE APPROVED.

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

--- Comment #8 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/trayscale

[Bug 2284159] Review Request: trayscale - Unofficial GUI wrapper around the Tailscale CLI client

https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Jonathan Wright  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-07-19 02:14:10