Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=447766
Summary: Review Request: mathomatic - Small, portable symbolic math program Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: terjeros@phys.ntnu.no QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
spec: http://terjeros.fedorapeople.org/mathomatic/mathomatic.spec srpm: http://terjeros.fedorapeople.org/mathomatic/mathomatic-14.0.3-1.fc9.src.rpm Description:
Mathomatic is a small, portable symbolic math program that can automatically solve, simplify, differentiate, combine, and compare algebraic equations, perform polynomial and complex arithmetic, etc. It was written by George Gesslein II and has been under development since 1986.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
------- Additional Comments From terjeros@phys.ntnu.no 2008-05-21 14:04 EST ------- koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=623197
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |michel.sylvan@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
------- Additional Comments From michel.sylvan@gmail.com 2008-06-04 00:06 EST ------- Looks good so far; could you update to 14.0.4 and then I can do a full review? Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(terjeros@phys.ntnu | |.no)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(terjeros@phys.ntnu| |.no) |
------- Additional Comments From terjeros@phys.ntnu.no 2008-06-04 17:15 EST -------
Looks good so far; could you update to 14.0.4 and then I can do a full review?
Sure:
spec: http://terjeros.fedorapeople.org/mathomatic/mathomatic.spec srpm: http://terjeros.fedorapeople.org/mathomatic/mathomatic-14.0.4-1.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
------- Additional Comments From michel.sylvan@gmail.com 2008-06-06 19:04 EST ------- Only one small problem: desktop-file-install is used without a vendor tag. Could you make it desktop-file-install --vendor="fedora" ... ?
(the exception is for packages that have their own vendor tags, e.g. KDE, GNOME, XFCE)
APPROVED
• rpmlint: clean • package name: ok • spec file name: ok • package guideline-compliant: ok • license complies with guidelines: ok • license field accurate: ok • license file not deleted: ok • spec in US English: ok • spec legible: ok • source matches upstream: ok • builds under >= 1 archs, others excluded: ok • build dependencies complete: ok • own all directories: ok • no dupes in %files: ok • permission: ok • %clean RPM_BUILD_ROOT: ok • macros used consistently: ok • Package contains code: ok • large docs => -doc: small enough • desktop file uses desktop-file-install: ok -- note: vendor tag missing • clean buildroot before install: ok • filenames UTF-8: ok
SHOULD • desc and summary contain translations if available • package build in mock on all architectures: none • package functioned as described: ok • scriplets are sane: ok (see note on vendor tag) • other subpackages should require versioned base: ok (though in this case it seems functionally independent) • require package not files: ok
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
------- Additional Comments From tibbs@math.uh.edu 2008-06-06 19:14 EST ------- Actually we're trying to reword the guideline about --vendor so that it's clear just what's supposed to be done with it. It seems that --vendor=fedora is rarely the right thing to do.
Check the discussion starting here: http://fedoraproject.org/wiki/Packaging/Minutes20080603#t12:15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From terjeros@phys.ntnu.no 2008-06-07 03:57 EST -------
Only one small problem: desktop-file-install is used without a vendor tag. Could you make it desktop-file-install --vendor="fedora" ... ?
Will have a look, thanks for comments tibbs.
APPROVED
Thanks for the review.
(fedora-review flag should be changed?)
New Package CVS Request ======================= Package Name: mathomatic Short Description: Small, portable symbolic math program Owners: terjeros Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com
------- Additional Comments From kevin@tummy.com 2008-06-08 13:55 EST ------- Michel: Can you set the fedora-review flag? Just want to make sure all is approved from your end.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From michel.sylvan@gmail.com 2008-06-09 01:32 EST ------- Ah yes, sorry.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-06-09 12:25 EST ------- thanks.
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathomatic - Small, portable symbolic math program
https://bugzilla.redhat.com/show_bug.cgi?id=447766
terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From terjeros@phys.ntnu.no 2008-06-09 14:51 EST ------- Thanks guys, package built and pending for testing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla