[Bug 501381] New: Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Summary: Review Request: 389-console - A Java based remote
                    management console used for managing 389
                    Administration Server and 389 Directory Server
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-console.spec
SRPM URL:
http://rmeggins.fedorapeople.org/pkgreview/389-console-1.1.3-2.src.rpm
Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.

This is a rename of fedora-idm-console to 389-console.

Source URL: http://port389.org/sources/389-console-1.1.3.tar.bz2
md5sum 389-console-1.1.3.tar.bz2 
bbf9b8e74b9746d65b1fd1871a665208  389-console-1.1.3.tar.bz2
sha1sum 389-console-1.1.3.tar.bz2 
f220b8d5b1b1a737f0744f2eef1e07ed8b5aa460  389-console-1.1.3.tar.bz2

Compiles cleanly in mock
rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm
389-console.i386: E: no-binary
- the only reason this is not a noarch package is because of the dependency on
jss which has a specific arch
389-console-debuginfo.i386: E: empty-debuginfo-package
- this is a java package

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Rich Megginson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|                            |389-console

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jochen Schmitt   2009-05-27 14:19:31 EDT ---
I have try to make a first look on this package.

Unfortunately, I could found any java sources.

The wrapper script try to call a java class which I could found in this
package.

It may nice, if you can give me a explaination.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #2 from Rich Megginson   2009-05-27 14:45:40 EDT ---
(In reply to comment #1)
> I have try to make a first look on this package.
>
> Unfortunately, I could found any java sources.
>
> The wrapper script try to call a java class which I could found in this
> package.
>
> It may nice, if you can give me a explaination.

Yes.  The 389-console package just provides the "skin" or "flavor" for the
console.  The console implementation package is idm-console-framework, which is
a requirement.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #3 from Rich Megginson   2009-06-04 10:24:05 EDT ---
Any takers?  What can I do to help this along?

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

--- Comment #4 from Jochen Schmitt   2009-06-04 12:43:18 EDT ---
Good:
+ Basename of the SPEC file matches with package name
+ Package name fullfill naming guidelines.
+ URL tag shows on proper project home page
+ Package contains valid license tag
+ License tag state GPLv2 as a valid OSS license
+ Package contains verbatin copy of the license text
+ Package contains proper Obsolete/Provides statement for renaming
+ Package contains no subpackages
+ Consistently usage of RPM macros
+ Proper definition of the BuildRoot
+ BuildRoot will be cleaned on beginning of %clean and %install
+ Could download upstream sources via spectool -g
+ Packaged sources matches with upstream
(md5sum: bbf9b8e74b9746d65b1fd1871a665208)
+ Local build works fine
+ Rpmlint is silent for source package
+ Scratch build on koji works fine.
* Files permissions are ok.
+ Java symlinks for jar files are created
+ All packaged files are owned by the package.
+ %doc stanza is small, so we don't need extra subpackage
+ Package contains proper %Changelog

Bad:
- Rpmlint complaints on binary rpm:
$ rpmlint -i 389-console-1.1.3-2.fc10.x86_64.rpm
389-console.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.
- Debuginfo package is empty

I want to suggest, that you should recreate this package as a
noarch package.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #5 from Rich Megginson   2009-06-04 13:13:55 EDT ---
> I want to suggest, that you should recreate this package as a
> noarch package.

I would like to do that.  The problem is that the package has a dependency on
jss which is not a noarch package.  How can I do that?

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #6 from Jochen Schmitt   2009-06-04 13:21:50 EDT ---
This is only possible, if jss is available for all architectures.

If not, please take care, that no debuginfo package may be created, because it
make no sense.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #7 from Jochen Schmitt   2009-06-04 13:24:10 EDT ---
I don't see any ExclusiveArch or ExcludeArch statements in jss, so creating of
a noarch package is possible.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #8 from Rich Megginson   2009-06-04 13:32:03 EDT ---
I don't know if jss is available for all architectures.  jss itself depends on
java, nspr, and nss.  If those are available, then jss should be available.

So if I create a noarch package, and I install 389-console on x86_64, how do I
make sure 389-console uses jss.x86_64?

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #9 from Jochen Schmitt   2009-06-04 13:40:39 EDT ---
Unfortunately, I'm not a java guru, so you make ask on the fedora-java-list
about mulitlib behaviour of jni environments.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

--- Comment #10 from Rich Megginson   2009-06-17 11:23:29 EDT ---
ok - the fedora package will be noarch - verified that it works correctly on
rawhide x86_64 - correctly pulls and uses jss.x86_64

Spec URL: http://rmeggins.fedorapeople.org/pkgreview/389-console.spec
SRPM URL:
http://rmeggins.fedorapeople.org/pkgreview/389-console-1.1.3-2.src.rpm
Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.

This is a rename of fedora-idm-console to 389-console.

Source URL: http://port389.org/sources/389-console-1.1.3.tar.bz2
md5sum 389-console-1.1.3.tar.bz2 
e9152a2e523a2890767a91cb338e2974  389-console-1.1.3.tar.bz2
sha1sum 389-console-1.1.3.tar.bz2 
73068de75b616d8d49ac570d23c007fec882bd89  389-console-1.1.3.tar.bz2

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Jochen Schmitt   2009-06-18 12:11:42 EDT ---
OK, seems to build fine on koji, so you are APPROVED

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Rich Megginson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #12 from Rich Megginson   2009-06-18 12:36:13 EDT ---
New Package CVS Request
=======================
Package Name: 389-console
Short Description: A Java based remote management console used for managing 389
Administration Server and 389 Directory Server.
Owners: rmeggins nkinder nhosoi
Branches: F-10 F-11

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #13 from Jason Tibbitts   2009-06-18 16:29:00 EDT ---
I used a "short description" that's actually short.  Otherwise, CVS done.

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Rich Megginson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #14 from Rich Megginson   2009-06-18 17:12:04 EDT ---
cvs import done - koji builds in rawhide - all branches committed

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Michael Stahnke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #15 from Michael Stahnke   2009-11-02 23:24:18 EDT ---
New Package CVS Request
=======================
Package Name: 389-console
Short Description: A Java based console used for managing 389
Administration Server and 389 Directory Server.
Owners: stahnma
Branches: EL4 EL5

[Bug 501381] Review Request: 389-console - A Java based remote management console used for managing 389 Administration Server and 389 Directory Server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=501381

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #16 from Kevin Fenzi   2009-11-02 23:45:42 EDT ---
cvs done.