Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Text-TabularDisplay/ OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-Text-TabularDisplay-1.22-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Text-TabularDisplay.spec
Description: Text::TabularDisplay simplifies displaying textual data in a table. The output is identical to the columnar display of query results in the mysql text monitor. For example, this data:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |240177 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2007-05-15 16:56 EST ------- I only have one question: The tests seem to need perl(Test) while you have a build-time dependency on perl(Test::More). At this point I'm not sure what the plan is, but as is I'd wager that you have the wrong BuildRequire there. Since we chatted about this on IRC, I'll go ahead and approve this and you can check in with the quick fix.
* source files match upstream: 87856a053cccba8059c194da15300271ea800ab37c44e01f34612be4da962317 Text-TabularDisplay-1.22.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream (GPL statement is in the code itself) * latest version is being packaged. ? BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Text::TabularDisplay) = 1.22 perl-Text-TabularDisplay = 1.22-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(integer) perl(strict) perl(vars)
* %check is present and all tests pass: All tests successful. Files=15, Tests=83, 0 wallclock secs ( 0.20 cusr + 0.14 csys = 0.34 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
------- Additional Comments From cweyl@alumni.drew.edu 2007-05-15 16:58 EST ------- New Package CVS Request ======================= Package Name: perl-Text-TabularDisplay Short Description: Display text in formatted table output Owners: cweyl@alumni.drew.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
------- Additional Comments From cweyl@alumni.drew.edu 2007-05-16 19:37 EST ------- Imported and building. As always, thanks for the review! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=240174
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2010-09-02 10:38:03 EDT --- Package Change Request ====================== Package Name: perl-Text-TabularDisplay New Branches: el6 Owners: iarnell tremble
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=240174
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2010-09-02 17:17:42 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org