Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libkexiv2 - an Exiv2 wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Summary: Review Request: libkexiv2 - an Exiv2 wrapper library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2-4.6.90-1.fc15.src... Description: an Exiv2 wrapper library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Alias| |libkexiv2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@googlemail.com
--- Comment #1 from nucleo alekcejk@googlemail.com 2011-07-06 13:14:02 EDT --- All files have GPLv2+ license excpept libkexiv2_export.h which is LGPLv2+.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3182914
rpmlint output:
libkexiv2.i686: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.src: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/libkexiv2-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.> libkexiv2.x86_64: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2-devel.i686: W: no-documentation libkexiv2-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 9 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #2 from nucleo alekcejk@googlemail.com 2011-07-06 13:30:45 EDT --- No icons and desktop files installed in this package so gtk-update-icon-cache and update-desktop-database not needed.
NEWS and ChangeLog files can be added in %doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com Flag| |fedora-review?
--- Comment #3 from nucleo alekcejk@googlemail.com 2011-07-09 10:54:59 EDT --- rmplint output on all libkexiv2-4.6.90-2 rpms:
libkexiv2.i686: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.i686: W: incoherent-version-in-changelog 4.6.90-1 ['4.6.90-2.fc15', '4.6.90-2'] libkexiv2.src: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.x86_64: W: summary-not-capitalized C an Exiv2 wrapper library libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.x86_64: W: incoherent-version-in-changelog 4.6.90-1 ['4.6.90-2.fc15', '4.6.90-2'] libkexiv2-devel.i686: W: no-documentation libkexiv2-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 10 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #4 from nucleo alekcejk@googlemail.com 2011-07-09 10:57:28 EDT --- So there are still issues with summary-not-capitalized and incoherent-version-in-changelog from rpmlint that should be fixed. Also license and scriptlets should be fixed then package can be approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #5 from nucleo alekcejk@googlemail.com 2011-07-09 19:40:46 EDT --- ChangeLog is outdated so it is enough to add NEWS in %doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2011-07-10 10:44:15 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkexiv2-4.6.90-3.fc15.src...
%changelog * Sun Jul 10 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-3 - License: GPLv2+ - fix Summary - %%doc: +ChangeLog NEWS - drop uneeded scriptlets - add %%check section
* Wed Jul 06 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-2 - fix URL - Conflicts: kdegraphics < 7:4.6.90-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: libkexiv2 - |Review Request: libkexiv2 - |an Exiv2 wrapper library |An Exiv2 wrapper library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from nucleo alekcejk@googlemail.com 2011-07-10 13:42:29 EDT --- Package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=3189685
rpmlint output for libkexiv2-4.6.90-3 rpms:
libkexiv2.i686: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.i686: W: file-not-utf8 /usr/share/doc/libkexiv2-4.6.90/ChangeLog libkexiv2.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal libkexiv2.x86_64: W: file-not-utf8 /usr/share/doc/libkexiv2-4.6.90/ChangeLog libkexiv2-devel.i686: W: no-documentation libkexiv2-devel.x86_64: W: no-documentation
I think that file-not-utf8 is not blocker (only 2 not utf-8 bytes appeared there accidentally).
Package and spec names are fine, license GPLv2+ is actual license used in libkexiv2 sources, scriptlets are fine (/sbin/ldconfig in %post and %postun) Package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=3189685
Package APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-cvs?
--- Comment #8 from Rex Dieter rdieter@math.unl.edu 2011-07-10 16:32:58 EDT --- Thanks.
New Package SCM Request ======================= Package Name: libkexiv2 Short Description: An Exiv2 wrapper library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #9 from nucleo alekcejk@googlemail.com 2011-07-10 21:21:13 EDT --- It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2 Sorry that I not noticed this before.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #10 from Jon Ciesla limb@jcomserv.net 2011-07-11 11:16:20 EDT --- pkgdb says this already exists.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #11 from Rex Dieter rdieter@math.unl.edu 2011-07-11 12:55:46 EDT --- doh, forgot about that, let's try change request instead then. fyi, this needs also to be marked not deprecated.
Package Change Request ====================== Package Name: libkexiv2 Short Description: An Exiv2 wrapper library Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:15:20 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limb@jcomserv.net
--- Comment #13 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:17:33 EDT --- Did f15 branch, can't do 1 and 3, you'll need to file a rel-eng trac.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-07-12 13:08:23
--- Comment #14 from Rex Dieter rdieter@math.unl.edu 2011-07-12 13:08:23 EDT --- imported
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719325
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |
package-review@lists.fedoraproject.org