https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Bug ID: 2259758 Summary: Review Request: rust-zopfli - Rust implementation of the Zopfli compression algorithm Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/rust-zopfli.spec SRPM URL: https://music.fedorapeople.org/rust-zopfli-0.8.0-1.fc39.src.rpm
Description:
A Rust implementation of the Zopfli compression algorithm.
Fedora Account System Username: music
PR to be merged after unretirement: https://src.fedoraproject.org/rpms/rust-zopfli/pull-request/1
Knowing this is sometimes a problem, I will check the changelog of the unretired package and make sure it is not broken.
To avoid packaging the nightly feature, I used (and would commit) the following rust2rpm.toml:
[features] hide = [ "nightly" ]
While I don’t intend to package the zopfli executable from this crate because it has the same name as the one from the zopfli package, packaging this library would allow unretiring and updating https://src.fedoraproject.org/rpms/rust-oxipng, which does provide a useful command-line tool.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/zo | |pfli
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6941969 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-zopfli Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2259760
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2259760 [Bug 2259760] Review Request: rust-oxipng - Lossless PNG compression optimizer
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
(skip the ones that are not relevant to unretirements)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
Before importing and building the package, please make sure to exclude some unnecessary files from the package (i.e. Makefile and rustfmt.toml). You can either use something like `%exclude %{crate_instdir}/Makefile`, or extend the "exclude" setting in Cargo.toml to `exclude = ["test/*", "/Makefile", "/rustfmt.toml"]`.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- Unretirement requested: https://pagure.io/releng/issue/11911
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4f25552e4f (rust-zopfli-0.8.0-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f25552e4f
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-02-08 17:40:55
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4f25552e4f (rust-zopfli-0.8.0-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-ca038edfdd (rust-zopfli-0.8.0-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ca038edfdd
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-ca038edfdd has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ca038edfdd *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ca038edfdd
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-67faff630e (rust-zopfli-0.8.0-2.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-67faff630e
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-67faff630e has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-67faff630e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-67faff630e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-ca038edfdd (rust-zopfli-0.8.0-2.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2259758
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-67faff630e (rust-zopfli-0.8.0-2.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org