[Bug 467182] New: Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hunspell-sc - Sardinian hunspell dictionary

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Summary: Review Request: hunspell-sc - Sardinian hunspell
                    dictionary
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-sc.spec
SRPM URL:
http://people.redhat.com/caolanm/hunspell/hunspell-sc-0.20040601-1.fc9.src.r...
Description: Sardinian hunspell dictionary

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग)   2008-10-29 02:41:49 EDT ---
SPEC is missing ">" in iconv command
koji build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=910282

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

--- Comment #2 from Caolan McNamara   2008-10-29 06:00:13 EDT ---
That was a bit silly:

New SPEC: http://people.redhat.com/caolanm/hunspell/hunspell-sc.spec
New SRPM:
http://people.redhat.com/caolanm/hunspell/hunspell-sc-0.20040601-2.fc9.src.r...

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Parag AN(पराग)   2008-11-01 01:34:33 EDT ---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=914108
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
05284890c3445c5850a3c1410790a057  aspell5-sc-1.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Caolan McNamara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #4 from Caolan McNamara   2008-11-01 07:58:58 EDT ---
New Package CVS Request
=======================
Package Name: hunspell-sc
Short Description: Sardinian hunspell dictionary
Owners: caolanm
Branches: 
InitialCC:

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #5 from Kevin Fenzi   2008-11-01 13:34:48 EDT ---
cvs done.

[Bug 467182] Review Request: hunspell-sc - Sardinian hunspell dictionary

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467182

Caolan McNamara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE