[Bug 443797] New: Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=443797

Summary: Review Request: comedilib - Data Acquisition library for
                    the Comedi driver
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://mmahut.fedorapeople.org/reviews/comedilib/comedilib.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/comedilib/comedilib.spec
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=578251
Description: Comedilib is a user-space library that provides a developer-friendly
interface to Comedi devices. Included in the Comedilib distribution
is documentation, configuration and calibration utilities,
and demonstration programs.

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver

https://bugzilla.redhat.com/show_bug.cgi?id=443797

------- Additional Comments From [e-mail]  2008-04-23 09:09 EST -------
SRPM URL:
http://mmahut.fedorapeople.org/reviews/comedilib/comedilib-0.8.1-1.fc8.src.r...

(correcting, so that QA script is happy)

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |443921
              nThis|                            |
              Alias|                            |comedilib-review

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

------- Additional Comments From [e-mail]  2008-05-07 05:55 EST -------
Thanks for the package, and sorry for the delay.
Here's the review:

1.) Source file is not available for download. Probably the correct URL is:
http://www.comedi.org/comedi/download/comedilib-0.8.1.tar.gz

2.) You should not use %makeinstall macro. See this document for reason:
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall

3.) The build in mock failed for me. Seems like it did not generate python
files, and failed to define %python_sitelib correctly. That might be because you
omitted python-devel from BuildRequires.

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

------- Additional Comments From [e-mail]  2008-05-07 17:27 EST -------
Hi Lubomir,

1) Fixed.
2) Fixed.
3) It builds fine for me...

http://koji.fedoraproject.org/koji/taskinfo?taskID=600026
    http://koji.fedoraproject.org/koji/taskinfo?taskID=600033

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-05-07 17:46 EST -------
Thanks for the fixes marek.
I see no more issues with the package;

APPROVED

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-07 18:22 EST -------
thank you,

New Package CVS Request
=======================
Package Name: comedilib
Short Description: Data Acquisition library for the Comedi driver
Owners: mmahut
Branches: EL-5, F-8, F-9
Cvsextras Commits: yes

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-08 13:42 EST -------
cvs done.

[Bug 443797] Review Request: comedilib - Data Acquisition library for the Comedi driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: comedilib - Data Acquisition library for the Comedi driver
Alias: comedilib-review

https://bugzilla.redhat.com/show_bug.cgi?id=443797

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-05-12 13:23 EST -------
thank you both, all done.