[Bug 1655421] New: Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Bug ID: 1655421
           Summary: Review Request: hw-probe - A tool to check operability
                    of computer hardware
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://github.com/linuxhw/build-stuff/releases/download/1.4-Fedora/hw-probe...
SRPM URL:
https://github.com/linuxhw/build-stuff/releases/download/1.4-Fedora/hw-probe...
Description: A tool to check operability of computer hardware and upload result
to the Linux hardware database.

Probe — is a snapshot of your computer's hardware state and system
logs. The tool returns a permanent URL to view the probe of the
computer.

The tool is intended to simplify collecting of logs necessary for
investigating hardware related problems. Just ask a user to run one
simple command to collect all the system logs at once:

sudo hw-probe -all -upload

By creating probes you contribute to the HDD/SSD Real-Life
Reliability Test study: https://github.com/linuxhw/SMART

Fedora Account System Username: andrewponomarenko

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Andrey Ponomarenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Vasiliy Glazov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vasiliy Glazov  ---
1. Remove Group:      Development/Other
2. Source0: must be URL to download sources.
3. Are you sure this need?
%define debug_package %{nil}
Also use %global instead of %define.
4. Instead
%setup -q -n hw-probe-%{version}
use new macro
%autosetup -n hw-probe-%{version}
5. Bugreport this to upstream
chmod 0644 README.md
6. Instead
make install prefix=%{_prefix} DESTDIR=%{buildroot}
use new macro
%make_install prefix=%{_prefix}
7. Remove clean section.
8. Remove %defattr(-,root,root,-) from %file section.
9. Add changelog section.

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #2 from Andrey Ponomarenko  ---
Fixed.

Thank you!

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #3 from Vasiliy Glazov  ---
Also change release to
Release:        1%{?dist}

Add license file to %files section.

Add new SRPM URL: in this bugreport.

But I can't be sponsor for you :(

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #4 from Andrey Ponomarenko  ---
Fixed.

SRPM URL:
https://github.com/linuxhw/build-stuff/releases/download/1.4-Fedora/hw-probe...

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #5 from Vasiliy Glazov  ---
Move license file from
%doc README.md LICENSE
to
%license LICENSE

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Neal Gompa  ---
Remove %ifarch in here, since you shouldn't use it with noarch packages.

Use "Recommends: mcelog" instead so that it tolerates it not being available.

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #7 from Dominik 'Rathann' Mierzejewski  ---
1. Use:

Source0:
https://github.com/linuxhw/hw-probe/archive/%%7Bversion%7D/%%7Bname%7D-%%7Bv...

or even:

Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz

2.
> %autosetup -n hw-probe-%{version}

You can drop the -n hw-probe-%{version}, it's the default.
> chmod 0644 README.md LICENSE

Why do you need chmod?

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #8 from Andrey Ponomarenko  ---
Fixed. Thank you!

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #9 from Vasiliy Glazov  ---
Change License tag to LGPLv2+.
Available name for licenses here
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
             Blocks|177841 (FE-NEEDSPONSOR)     |
           Assignee|[e-mail]    |[e-mail]

--- Comment #10 from Igor Gnatenko  ---
I'm going to sponsor you and review this package.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #11 from Igor Gnatenko  ---
So it seems that Vasily and Dominik made your specfile look almost good.

* Correct License tag as described above.
* Add BuildRequires: perl-generators, so `use …` are converted to dependencies.
> Requires:   perl
> Requires:   perl-libwww-perl

You don't need these two.

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Miroslav Suchý  ---
You need to add

BuildRequires: perl

so you have perl available in build time.

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #13 from Miroslav Suchý  ---
It is missing a man page.

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #14 from Andrey Ponomarenko  ---
(In reply to Igor Gnatenko from comment #10)
> I'm going to sponsor you and review this package.

Thank you!

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #15 from Andrey Ponomarenko  ---
(In reply to Igor Gnatenko from comment #11)
> Add BuildRequires: perl-generators, so `use …` are converted to
>
> dependencies.
> > Requires:   perl
> > Requires:   perl-libwww-perl
>
> You don't need these two.

Most of the modules (including perl-libwww-perl) are imported by `require ...`,
not `use ...`. Is it OK to remove perl-libwww-perl from deps in this case?

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #16 from Andrey Ponomarenko  ---
(In reply to Igor Gnatenko from comment #10)
> I'm going to sponsor you and review this package.

Tried to continue at
https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source...,
but got an error:

]$ fedpkg request-repo hw-probe 1655421
Could not execute request_repo: The Bugzilla bug is not approved yet

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

Michal Schorm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(i.gnatenko.brain@
                   |                            |gmail.com)

[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1655421

--- Comment #17 from Jason Tibbitts  ---
Well, he said that he would review it, not that he had approved it.