https://bugzilla.redhat.com/show_bug.cgi?id=1286554
Bug ID: 1286554 Summary: Review Request: eclipse-m2e-takari - M2E Takari connector Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: mizdebsk@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 652183 (FE-JAVASIG)
Spec URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-takari/eclipse-m2e-takar... SRPM URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-takari/eclipse-m2e-takar... Description: This package provides Takari connector for Eclipse M2E. Fedora Account System Username: mizdebsk
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1286554
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |msimacek@redhat.com Assignee|nobody@fedoraproject.org |msimacek@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1286554
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Michael Simacek msimacek@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "EPL-1.0", "Unknown or generated". 40 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1286554-eclipse-m2e-takari/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/eclipse/droplets [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/eclipse/droplets, /usr/share/eclipse [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local
Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: eclipse-m2e-takari-0.1.0-0.1.git780a6e9.fc24.noarch.rpm eclipse-m2e-takari-0.1.0-0.1.git780a6e9.fc24.src.rpm eclipse-m2e-takari.noarch: W: no-documentation eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/slf4j.simple_1.7.13.jar ../../../../../java/slf4j/simple.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/slf4j.api_1.7.13.jar ../../../../../java/slf4j/slf4j-api.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/com.google.guava_18.0.0.jar ../../../../../java/guava.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/io.takari.incrementalbuild.workspace_0.20.1.jar ../../../../../java/takari-incrementalbuild/incrementalbuild-workspace.jar 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory eclipse-m2e-takari.noarch: W: no-documentation eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/slf4j.simple_1.7.13.jar ../../../../../java/slf4j/simple.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/com.google.guava_18.0.0.jar ../../../../../java/guava.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/slf4j.api_1.7.13.jar ../../../../../java/slf4j/slf4j-api.jar eclipse-m2e-takari.noarch: W: dangling-relative-symlink /usr/share/eclipse/droplets/m2e-takari/eclipse/plugins/io.takari.incrementalbuild.workspace_0.20.1.jar ../../../../../java/takari-incrementalbuild/incrementalbuild-workspace.jar 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Requires -------- eclipse-m2e-takari (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(io.takari:incrementalbuild-workspace) osgi(com.google.guava) osgi(io.takari.incrementalbuild.workspace) osgi(org.eclipse.jdt.core) osgi(org.eclipse.m2e.core) osgi(org.eclipse.m2e.jdt) osgi(org.eclipse.m2e.maven.runtime) osgi(slf4j.api)
Provides -------- eclipse-m2e-takari: eclipse-m2e-takari mvn(io.takari.m2e:io.takari.m2e.incrementalbuild.core) mvn(io.takari.m2e:io.takari.m2e.jar) mvn(io.takari.m2e:io.takari.m2e.jdt.core) mvn(io.takari.m2e:io.takari.m2e.lifecycle.feature) mvn(io.takari.m2e:io.takari.m2e.lifecycle:pom:) osgi(io.takari.m2e.incrementalbuild.core) osgi(io.takari.m2e.jar) osgi(io.takari.m2e.jdt.core) osgi(io.takari.m2e.lifecycle.feature)
Source checksums ---------------- https://github.com/takari/io.takari.m2e.lifecycle/archive/780a6e9a2cd3fbedc9... : CHECKSUM(SHA256) this package : 8b733634fd7a9071327a416f8819e2d54ecd6290285e50c88fced2d5ec436e94 CHECKSUM(SHA256) upstream package : 8b733634fd7a9071327a416f8819e2d54ecd6290285e50c88fced2d5ec436e94
Jar and class files in source ----------------------------- ./io.takari.m2e.lifecycle-780a6e9a2cd3fbedc950ecad9e7d04fa423db2a1/io.takari.m2e.jar
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1286554 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
No problems spotted. f-r warnings are false positives. APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1286554
--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/eclipse-m2e-takari
https://bugzilla.redhat.com/show_bug.cgi?id=1286554
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks|652183 (FE-JAVASIG) | Resolution|--- |RAWHIDE Last Closed| |2015-12-02 10:54:53
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- Built for rawhide and F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12030681 http://koji.fedoraproject.org/koji/taskinfo?taskID=12030684
Closing.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla