Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
Bug ID: 908788 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: psabata@redhat.com
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-Perl-Stripper/perl-Perl-Stripper.s... SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-Perl-Stripper/perl-Perl-Stripper-0... Description: This module is yet another PPI-based Perl source code stripper. Its focus is on customization and stripping significant information from source code. Fedora Account System Username: psabata
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: |package name here> - <short |perl-Perl-Stripper - Yet |summary here> |another PPI-based Perl | |source code stripper
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: ed134dec1e0735af5a872a2ff299837d973e23cc83e2da3e468c63696f655d13). Ok. Summary verified from lib/Perl/Stripper.pm. Ok. Description verified from lib/Perl/Stripper.pm. Ok. License verified from LICENSE, lib/Perl/Stripper.pm, README. Ok. No XS code, noarch BuildArch is Ok.
TODO: You can build-require `perl(vars)' for consistency (t/data/1.pl:4).
Test::Script is optional. Ok.
Test::Pod is not used. Ok. Test::Pod::Coverage is not used. Ok. Pod::Coverage::TrustPod is not used. Ok.
All tests pass. Ok.
$ rpmlint perl-Perl-Stripper.spec ../SRPMS/perl-Perl-Stripper-0.04-1.fc19.src.rpm ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Feb 7 17:50 /usr/share/doc/perl-Perl-Stripper-0.04 -rw-r--r-- 1 root root 366 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/Changes -rw-r--r-- 1 root root 18356 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/LICENSE -rw-r--r-- 1 root root 6467 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/README -rw-r--r-- 1 root root 4443 Feb 7 17:50 /usr/share/man/man3/Perl::Stripper.3pm.gz drwxr-xr-x 2 root root 0 Feb 7 17:50 /usr/share/perl5/vendor_perl/Perl -rw-r--r-- 1 root root 10787 Feb 7 17:50 /usr/share/perl5/vendor_perl/Perl/Stripper.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c 1 perl >= 1:5.010 1 perl(Log::Any) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Moo) 1 perl(PPI) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Perl::Stripper) = 0.04 1 perl-Perl-Stripper = 0.04-1.fc19 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4936677). Ok.
Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Petr Šabata psabata@redhat.com --- (In reply to comment #1)
TODO: You can build-require `perl(vars)' for consistency (t/data/1.pl:4).
This file is used for testing only, not actually executed, if I understand it correctly.
Resolution: Package APPROVED.
Thank you.
---
New Package SCM Request ======================= Package Name: perl-Perl-Stripper Short Description: Yet another PPI-based Perl source code stripper Owners: psabata jplesnik ppisar Branches: f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #4 from Petr Šabata psabata@redhat.com --- Thank you.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Perl-Stripper-0.04-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Perl-Stripper-0.04-1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Perl-Stripper-0.04-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Perl-Stripper-0.04-1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Perl-Stripper-0.04-1.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908788
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Perl-Stripper-0.04-1.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=908788
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Perl-Stripper-0.04-1.f | |c17 Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-03 09:36:19
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla