[Bug 785274] New: Review Request: mingw-goocanvas2 - MinGW Windows canvas library for GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mingw-goocanvas2 - MinGW Windows canvas library for GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=785274
Summary: Review Request: mingw-goocanvas2 - MinGW Windows canvas library for GTK+ Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalevlember@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://kalev.fedorapeople.org/mingw-goocanvas2.spec SRPM URL: http://kalev.fedorapeople.org/mingw-goocanvas2-2.0.1-1.fc16.src.rpm Description: GooCanvas is a canvas widget for GTK+ that uses the cairo 2D library for drawing.
This package contains the MinGW Windows cross compiled GooCanvas 2.0 library.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785274
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@vanpienbroek.nl Flag| |fedora-review+
--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2012-01-31 11:44:17 EST --- $ rpmlint mingw-goocanvas2.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw-goocanvas2-2.0.1-1.fc16.src.rpm mingw-goocanvas2.src: W: spelling-error %description -l en_US cairo -> Cairo, cairn 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint noarch/mingw32-goocanvas2-2.0.1-1.fc16.noarch.rpm mingw32-goocanvas2.noarch: W: spelling-error %description -l en_US cairo -> Cairo, cairn mingw32-goocanvas2.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-goocanvas2-2.0.1/COPYING 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
$ rpm --query --requires mingw32-goocanvas2 mingw32(kernel32.dll) mingw32(libatk-1.0-0.dll) mingw32(libcairo-2.dll) mingw32(libgdk-3-0.dll) mingw32(libgdk_pixbuf-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(libgtk-3-0.dll) mingw32(libpango-1.0-0.dll) mingw32(libpangocairo-1.0-0.dll) mingw32(msvcrt.dll) mingw32-runtime mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --provides mingw32-goocanvas2 mingw32(libgoocanvas-2.0-9.dll) mingw32-goocanvas2 = 2.0.1-1.fc16
$ rpm --query --fileprovide mingw32-goocanvas2 /usr/i686-pc-mingw32/sys-root/mingw/bin/libgoocanvas-2.0-9.dll mingw32(libgoocanvas-2.0-9.dll) /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0 /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvas.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasellipse.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasenumtypes.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasgrid.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasgroup.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasimage.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasitem.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasitemmodel.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasitemsimple.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasmarshal.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvaspath.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvaspolyline.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasrect.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasstyle.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvastable.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvastext.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvasutils.h /usr/i686-pc-mingw32/sys-root/mingw/include/goocanvas-2.0/goocanvaswidget.h /usr/i686-pc-mingw32/sys-root/mingw/lib/libgoocanvas-2.0.dll.a /usr/i686-pc-mingw32/sys-root/mingw/lib/libgoocanvas-2.0.la /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/goocanvas-2.0.pc /usr/i686-pc-mingw32/sys-root/mingw/share/locale/en_GB/LC_MESSAGES/goocanvas2.mo /usr/i686-pc-mingw32/sys-root/mingw/share/locale/es/LC_MESSAGES/goocanvas2.mo /usr/i686-pc-mingw32/sys-root/mingw/share/locale/ja/LC_MESSAGES/goocanvas2.mo /usr/i686-pc-mingw32/sys-root/mingw/share/locale/sv/LC_MESSAGES/goocanvas2.mo /usr/share/doc/mingw32-goocanvas2-2.0.1 /usr/share/doc/mingw32-goocanvas2-2.0.1/COPYING
$ wget --quiet http://download.gnome.org/sources/goocanvas/2.0/goocanvas-2.0.1.tar.xz -O - | md5sum 78a98fa526ce73a77a454711c96f07a2 - $ md5sum goocanvas-2.0.1.tar.xz 78a98fa526ce73a77a454711c96f07a2 goocanvas-2.0.1.tar.xz
+ OK ! Needs to be looked into / Not applicable * Overridden by MinGW guidelines
[+] Files are installed in /usr/i686-pc-mingw32/sys-root/mingw [+] BuildRequires: mingw32-filesystem >= xx is in the .spec file [+] Requires are OK [+] BuildArch: noarch [+] No man pages or info files [+] default strip and objdump commands are overridden with mingw32 specific ones
[+] rpmlint must be run on every package. The output should be posted in the review [+] MUST: The package must be named according to the Package Naming Guidelines [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines [+] MUST: The package must meet the Packaging Guidelines [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [/] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. [+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [/] MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [/] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [/] MUST: Large documentation files should go in a -doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [*] MUST: Header files must be in a -devel package. [/] MUST: Static libraries must be in a -static package. [+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [/] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [/] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [*] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [/] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [/] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [/] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See MockTricks for details on how to do this. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [/] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [/] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [*] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. [/] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
The rpmlint warning about the FSF address could be filed upstream, but isn't blocking for review
====================================================== The package mingw-goocanvas2 is APPROVED by epienbro ======================================================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785274
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Kalev Lember kalevlember@gmail.com 2012-01-31 11:52:32 EST --- Thanks for the review, Erik!
New Package SCM Request ======================= Package Name: mingw-goocanvas2 Short Description: MinGW Windows canvas library for GTK+ Owners: kalev epienbro Branches: f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785274
--- Comment #3 from Jon Ciesla limburgher@gmail.com 2012-01-31 12:39:53 EST --- Git done (by process-git-requests).
Erik, please take ownership of review BZs. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785274
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |erik-fedora@vanpienbroek.nl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785274
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |mingw-goocanvas2-2.0.1-2.fc | |16 Resolution| |NEXTRELEASE Last Closed| |2012-01-31 13:05:17
--- Comment #4 from Kalev Lember kalevlember@gmail.com 2012-01-31 13:05:17 EST --- Package imported and built; closing the ticket.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla