[Bug 1292216] New: Review Request: libwhirlpool - Whirlpool cryptographic hash function library - package-review

List overview All Threads
Download

newer

[Bug 1292216] New: Review Request: libwhirlpool - Whirlpool cryptographic hash function library

older

[Bug 1297527] New: Review Request:...

[Bug 1290530] New: Review Request:...

Red Hat Bugzilla

16 Dec 2015 16 Dec '15

7:36 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Bug ID: 1292216 Summary: Review Request: libwhirlpool - Whirlpool cryptographic hash function library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: denis@fateyev.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: http://www.fateyev.com/RPMS/Fedora22/libwhirlpool.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora22/libwhirlpool-1.0-1.fc24.src.rpm Description: WHIRLPOOL cryptographic hash function library for UNIX and Linux. Also provides 'whirlpoolsum' utility for easy calculation and checking WHIRLPOOL hashes similar to 'md5sum' and 'shaXXXsum'. Fedora Account System Username: dfateyev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=12217746 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=12217724 (EPEL 7)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

7 Jan 7 Jan

2:56 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- dfateyev's scratch build of libwhirlpool-1.0-1.fc20.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12449773

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Jan 15 Jan

11:53 a.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Antonio Trande anto.trande@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:29 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Antonio Trande anto.trande@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #2 from Antonio Trande anto.trande@gmail.com --- Package approved.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "*No copyright* BSD", "*No copyright* Public domain BSD", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/1292216-libwhirlpool/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: EPEL5 requires explicit %clean with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)

===== SHOULD items =====

Generic: [x]: Explicit BuildRoot: tag as required by EPEL5 present. Note: Missing buildroot (required for EPEL5) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libwhirlpool-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: libwhirlpool-1.0-1.fc24.x86_64.rpm libwhirlpool-devel-1.0-1.fc24.x86_64.rpm libwhirlpool-debuginfo-1.0-1.fc24.x86_64.rpm libwhirlpool-1.0-1.fc24.src.rpm libwhirlpool.x86_64: W: spelling-error Summary(en_US) cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.x86_64: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.x86_64: W: spelling-error %description -l en_US shaXXXsum libwhirlpool-devel.x86_64: W: only-non-binary-in-usr-lib libwhirlpool-devel.x86_64: W: no-documentation libwhirlpool.src: W: spelling-error Summary(en_US) cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.src: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.src: W: spelling-error %description -l en_US whirlpoolsum -> whirlpool sum, whirlpool-sum, whirlpools um libwhirlpool.src: W: spelling-error %description -l en_US shaXXXsum 4 packages and 0 specfiles checked; 0 errors, 9 warnings.

Rpmlint (debuginfo) ------------------- Checking: libwhirlpool-debuginfo-1.0-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libwhirlpool-devel.x86_64: W: only-non-binary-in-usr-lib libwhirlpool-devel.x86_64: W: no-documentation libwhirlpool.x86_64: W: spelling-error Summary(en_US) cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.x86_64: W: spelling-error %description -l en_US cryptographic -> cryptography, cryptographer, crystallographic libwhirlpool.x86_64: W: spelling-error %description -l en_US shaXXXsum 3 packages and 0 specfiles checked; 0 errors, 5 warnings.

Requires -------- libwhirlpool-debuginfo (rpmlib, GLIBC filtered):

libwhirlpool-devel (rpmlib, GLIBC filtered): libwhirlpool(x86-64) libwhirlpool.so.0()(64bit)

libwhirlpool (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libwhirlpool.so.0()(64bit) rtld(GNU_HASH)

Provides -------- libwhirlpool-debuginfo: libwhirlpool-debuginfo libwhirlpool-debuginfo(x86-64)

libwhirlpool-devel: libwhirlpool-devel libwhirlpool-devel(x86-64)

libwhirlpool: libwhirlpool libwhirlpool(x86-64) libwhirlpool.so.0()(64bit)

Source checksums ---------------- https://github.com/dfateyev/libwhirlpool/archive/v1.0.tar.gz : CHECKSUM(SHA256) this package : 6c21e3a2c0c8ac7f933ce358e24808218ce9a2507e018714a20b3ab304b85af2 CHECKSUM(SHA256) upstream package : 6c21e3a2c0c8ac7f933ce358e24808218ce9a2507e018714a20b3ab304b85af2

Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./try-fedora-review -D EPEL5=1 -m fedora-rawhide-x86_64 -b 1292216 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #3 from Denis Fateyev denis@fateyev.com --- Thanks for the review. Please let me know if you need to review your package.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:37 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/libwhirlpool

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d8f8d36f56

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-969ea72593

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1f063da3ad

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:26 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-531deb5642

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Jan 16 Jan

4:48 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d8f8d36f56

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:21 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-969ea72593

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:24 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-531deb5642

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:49 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-71fb68b388

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Jan 17 Jan

3:22 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1f063da3ad

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

24 Jan 24 Jan

11:50 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:50 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

26 Jan 26 Jan

7:27 p.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Jan 31 Jan

8:21 a.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Feb 1 Feb

2:53 a.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:56 a.m.

New subject: [Bug 1292216] Review Request: libwhirlpool - Whirlpool cryptographic hash function library

https://bugzilla.redhat.com/show_bug.cgi?id=1292216

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- libwhirlpool-1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3460

Age (days ago)

3507

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla