[Bug 2165448] New: Review Request: google-noto-sans-cjk-fonts - Google Noto Sans CJK Fonts
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Bug ID: 2165448 Summary: Review Request: google-noto-sans-cjk-fonts - Google Noto Sans CJK Fonts Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pwu@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts.sp... SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts-20... Description: Google Noto Sans CJK Fonts Fedora Account System Username:pwu
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Peng Wu pwu@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |panemade@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5359122 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- You can drop below lines which are not needed in this SPEC file as there is no doc files to install. %global fontdocs *.txt %global fontdocsex %{fontlicenses}
Use %autosetup instead of just %setup in SPEC file
What is the source URL to download the Source0 archive? if possible can it be added there?
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Akira TAGOH tagoh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tagoh@redhat.com
--- Comment #3 from Akira TAGOH tagoh@redhat.com --- Why do you not follow the upstream versioning to package it? that would cause a confusion.
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- Found it https://github.com/googlefonts/noto-cjk/releases/download/Sans2.004/03_NotoS... Please use this URL.
Also as upstream has started using version numbers, good to use that, so Version: 2.004 With this change, you need to add obsoletes and provides to SPEC file and drop conflicts:
I think this package should provide 2 subpackages per family google-noto-sans-cjk-fonts google-noto-sans-mono-cjk-fonts
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- I just realized upstream archive provides ttc files which can contain multiple families. So in this case no need to have subpackages. You can continue using current spec. Also, Conflicts is needed so add a comment why it needs to be there in SPEC file.
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #6 from Peng Wu pwu@redhat.com --- Okay, I just updated the package to follow the upstream versioning, and added one comment in the spec file.
Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts.sp... SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-fonts-2....
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #7 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1941709 --> https://bugzilla.redhat.com/attachment.cgi?id=1941709&action=edit The .spec file difference from Copr build 5359122 to 5402185
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #8 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5402185 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- This package looks good now. Will approve along with review bug 2165453
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #11 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/google-noto-sans-cjk-fonts
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
--- Comment #12 from Peng Wu pwu@redhat.com --- Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2165448
Peng Wu pwu@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2023-02-10 03:33:35
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com