[Bug 1663283] New: Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Bug ID: 1663283 Summary: Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zendd... SRPM URL: http://rpms.remirepo.net/SRPMS/php-zendframework-zenddiagnostics-1.3.1-1.rem... Description: Perform diagnostic tests within real-world PHP applications.
Fedora Account System Username: remi
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1663245, 1663221
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1663221 [Bug 1663221] Review Request: php-doctrine-migrations - PHP Doctrine Migrations project https://bugzilla.redhat.com/show_bug.cgi?id=1663245 [Bug 1663245] Review Request: php-sensiolabs-security-checker - A security checker for your composer.lock
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Updated to 1.4: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zendd...
Spec URL: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zendd... SRPM URL: http://rpms.remirepo.net/SRPMS/php-zendframework-zenddiagnostics-1.4.0-1.rem...
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Build error:
DEBUG util.py:490: BUILDSTDERR: No matching package to install: '(php-composer(doctrine/migrations) >= 1.0 with php-composer(doctrine/migrations) < 2)' DEBUG util.py:490: BUILDSTDERR: No matching package to install: '(php-composer(sensiolabs/security-checker) >= 5.0 with php-composer(sensiolabs/security-checker) < 6)' DEBUG util.py:490: BUILDSTDERR: Not all dependencies satisfied DEBUG util.py:490: BUILDSTDERR: Error: Some packages could not be found.
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- My bad' didn't see the deps.
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- I've got a test error:
Time: 1.57 seconds, Memory: 10.00MB There was 1 error: 1) ZendDiagnosticsTest\DiskUsageTest::testCheck InvalidArgumentException: Invalid warningThreshold argument - expecting an integer between 1 and 100 /builddir/build/BUILDROOT/php-zendframework-zenddiagnostics-1.4.0-1.fc30.x86_64/usr/share/php/ZendDiagnostics/Check/DiskUsage.php:68 /builddir/build/BUILD/zend-diagnostics-79d0b7d0a1cab8f18e73d76ff1c2ec028f113840/test/DiskUsageTest.php:40
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Very strange... I cannot reproduce, and InvalidArgumentException is exactly the expected / tested exception by this test... so not an error...
Will try a scratch as soon as possible (when doctrine/migrations will be available)
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Bug 1663283 depends on bug 1663221, which changed state.
Bug 1663221 Summary: Review Request: php-doctrine-migrations - PHP Doctrine Migrations project https://bugzilla.redhat.com/show_bug.cgi?id=1663221
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Scratch build:
I encounter another failure, because this test is 64-bit only
1) ZendDiagnosticsTest\DiskFreeTest::testJitFreeSpace Failed asserting that ZendDiagnostics\Result\Success Object (...) is an instance of interface "ZendDiagnostics\Result\FailureInterface". /builddir/build/BUILD/zend-diagnostics-79d0b7d0a1cab8f18e73d76ff1c2ec028f113840/test/DiskFreeTest.php:136
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32740679
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #8 from Remi Collet fedora@famillecollet.com --- I will simply ignore these failure for now, and investigate them later
https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zendd...
Spec URL: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zendd... SRPM URL: http://rpms.remirepo.net/SRPMS/php-zendframework-zenddiagnostics-1.4.0-2.rem...
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32741220
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Bug 1663283 depends on bug 1663245, which changed state.
Bug 1663245 Summary: Review Request: php-sensiolabs-security-checker - A security checker for your composer.lock https://bugzilla.redhat.com/show_bug.cgi?id=1663245
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #9 from Remi Collet fedora@famillecollet.com --- @Robert-André Mauchin can you please check with latest changes ?
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #10 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD 3-clause "New" or "Revised" License", "Unknown or generated". 94 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/php-zendframework-zenddiagnostics/review- php-zendframework-zenddiagnostics/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [-]: Run phpci static analyze on all php files. Note: Test run failed
Rpmlint ------- Checking: php-zendframework-zenddiagnostics-1.4.0-2.fc30.noarch.rpm php-zendframework-zenddiagnostics-1.4.0-2.fc30.src.rpm php-zendframework-zenddiagnostics.src: W: invalid-url Source0: 79d0b7d0a1cab8f18e73d76ff1c2ec028f113840/php-zendframework-zenddiagnostics-1.4.0-79d0b7d.tgz 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #11 from Remi Collet fedora@famillecollet.com --- Thanks!
SCM requests https://pagure.io/releng/fedora-scm-requests/issue/9831 https://pagure.io/releng/fedora-scm-requests/issue/9832
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
--- Comment #12 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-zendframework-zenddiagnostics
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2021-06-26 12:43:31
--- Comment #13 from Mattia Verga mattia.verga@protonmail.com --- Package has been imported and then retired
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com