[Bug 718931] New: Review Request: perl-Net-Server-SS-PreFork - Hot-deployable variant of Net::Server::PreFork
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Net-Server-SS-PreFork - Hot-deployable variant of Net::Server::PreFork
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Summary: Review Request: perl-Net-Server-SS-PreFork - Hot-deployable variant of Net::Server::PreFork Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: emmanuel.seyman@club-internet.fr QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Net-Server-SS-PreFork/perl-Net... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Net-Server-SS-PreFork/perl-Net... Description: Net::Server::SS::PreFork is a Net::Server personality, extending Net::Server::PreFork. It can be run by the start_server script of Server::Starter.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |718932(perl-Starman)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #1 from Remi Collet fedora@famillecollet.com 2011-07-05 11:22:28 EDT --- + /usr/bin/perl Makefile.PL INSTALLDIRS=vendor *** Module::AutoInstall version 1.03 *** Checking for Perl dependencies... [Core Features] - LWP::Simple ...loaded. (5.827) - Test::TCP ...loaded. (0.16 >= 0.06) - HTTP::Server::Simple::CGI ...missing. - Net::Server ...loaded. (0.97) - Server::Starter ...loaded. (0.11 >= 0.02) ==> Auto-install the 1 mandatory module(s) from CPAN? [y] n
After analyse, perl-HTTP-Server-Simple should requires perl-CGI.
Please 1/ Open a bug against perl-HTTP-Server-Simple 2/ Add a temporary BR perl-CGI
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |fedora@famillecollet.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #2 from Remi Collet fedora@famillecollet.com 2011-07-05 11:45:18 EDT --- === FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated
=== REQUIRED ITEMS === [x] Rpmlint output: perl-Net-Server-SS-PreFork.src: I: checking perl-Net-Server-SS-PreFork.src: W: spelling-error Summary(en_US) deployable -> deplorable, deploy able, deploy-able perl-Net-Server-SS-PreFork.src: I: checking-url http://search.cpan.org/dist/Net-Server-SS-PreFork/ (timeout 10 seconds) perl-Net-Server-SS-PreFork.src: I: checking-url http://www.cpan.org/authors/id/K/KA/KAZUHO/Net-Server-SS-PreFork-0.05.tar.gz (timeout 10 seconds) perl-Net-Server-SS-PreFork.noarch: I: checking perl-Net-Server-SS-PreFork.noarch: W: spelling-error Summary(en_US) deployable -> deplorable, deploy able, deploy-able perl-Net-Server-SS-PreFork.noarch: W: incoherent-version-in-changelog 0.05-1 ['0.05-1.fc15.remi', '0.05-1.remi'] perl-Net-Server-SS-PreFork.noarch: I: checking-url http://search.cpan.org/dist/Net-Server-SS-PreFork/ (timeout 10 seconds) perl-Net-Server-SS-PreFork.spec: I: checking-url http://www.cpan.org/authors/id/K/KA/KAZUHO/Net-Server-SS-PreFork-0.05.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 3 warnings. [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : 4198d48d27353f60cc297178f86c216f Net-Server-SS-PreFork-0.05.tar.gz [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f15 x86_64 [x] Package is not known to require ExcludeArch [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Packages don't bundle copies of system librarie [x] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages with %{?_isa}, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI [x] All filenames in rpm packages must be valid UTF-8 [-] Package does not own files or directories owned by other packages. (Perl exception)
=== SUGGESTED ITEMS === [x] Final requires perl(:MODULE_COMPAT_5.12.4) perl(Net::Server::PreFork) perl(Net::Server::Proto::TCP) perl(Server::Starter) [x] Final provides perl(Net::Server::SS::PreFork) = 0.05 perl-Net-Server-SS-PreFork = 0.05-1.fc15.remi [x] Latest version is packaged. [?] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [-] Reviewer should test that the package builds in mock. Tested on: Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=3180974 [-] The package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] If scriptlets are used, those scriptlets must be sane. [ ] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [x] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [-] The placement of pkgconfig(.pc) files is correct. [x] %check is present and the tests pass
MUST : only the perl-CGI BR issue (I have add it to be able to build in mock/koji)
Should : I always prefer more explicit %file (wildcard are the devil) %{perl_vendorlib}/Net %{_mandir}/man3/Net*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #3 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2011-07-05 11:51:55 EDT --- (In reply to comment #2)
MUST : only the perl-CGI BR issue (I have add it to be able to build in mock/koji)
Done.
Should : I always prefer more explicit %file (wildcard are the devil) %{perl_vendorlib}/Net %{_mandir}/man3/Net*
You're right. Done.
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Net-Server-SS-PreFork/perl-Net... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Net-Server-SS-PreFork/perl-Net...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Remi Collet fedora@famillecollet.com 2011-07-05 11:56:12 EDT --- All MUST and Should fixed.
========== APPROVED ==========
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Emmanuel Seyman emmanuel.seyman@club-internet.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Emmanuel Seyman emmanuel.seyman@club-internet.fr 2011-07-05 12:03:20 EDT --- Thanks, Remi.
New Package SCM Request ======================= Package Name: perl-Net-Server-SS-PreFork Short Description: Hot-deployable variant of Net::Server::PreFork Owners: eseyman Branches: f15 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-07-05 12:11:40 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-07-05 14:12:26 EDT --- perl-Net-Server-SS-PreFork-0.05-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Net-Server-SS-PreFork-0.05-2.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-07-06 17:25:12 EDT --- perl-Net-Server-SS-PreFork-0.05-2.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-07-14 21:20:09 EDT --- perl-Net-Server-SS-PreFork-0.05-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=718931
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Net-Server-SS-PreFork- | |0.05-2.fc15 Resolution| |ERRATA Last Closed| |2011-07-14 21:20:16
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla