[Bug 2259449] New: Review Request: rocm-rpp - ROCm Performance Primatives for compute vision
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Bug ID: 2259449 Summary: Review Request: rocm-rpp - ROCm Performance Primatives for compute vision Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: trix@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/rocm-rpp.spec SRPM URL: https://trix.fedorapeople.org/rocm-rpp-6.0.0-1.fc40.src.rpm
AMD ROCm Performance Primitives (RPP) library is a comprehensive, high-performance computer vision library for AMD processors that have HIP, OpenCL, or CPU backends.
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rocm-packagers-sig@lists.fe | |doraproject.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/ROCm/%%7Bu | |pstreamname}
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6937236 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #2 from Tom Rix trix@redhat.com --- Spec URL: https://trix.fedorapeople.org/rocm-rpp.spec SRPM URL: https://trix.fedorapeople.org/rocm-rpp-6.0.0-1.fc40.src.rpm
For the buildrequires: clang
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2009907 --> https://bugzilla.redhat.com/attachment.cgi?id=2009907&action=edit The .spec file difference from Copr build 6937236 to 6943268
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6943268 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@bachelot.org Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #5 from Tom Rix trix@redhat.com --- Spec URL: https://trix.fedorapeople.org/rocm-rpp.spec SRPM URL: https://trix.fedorapeople.org/rocm-rpp-6.0.2-1.fc41.src.rpm
Updated to 6.0.2 Use llvm17 compat Add a %check
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |Tom.Rix@amd.com
--- Comment #6 from Tom.Rix@amd.com --- Spec URL: https://trix.fedorapeople.org/rocm-rpp.spec SRPM URL: https://trix.fedorapeople.org/rocm-rpp-6.2.0-1.fc42.src.rpm
Updated to 6.2.0
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@cavalca.name Flags| |fedora-review? Assignee|nobody@fedoraproject.org |davide@cavalca.name Status|NEW |ASSIGNED
--- Comment #7 from Davide Cavalca davide@cavalca.name --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #8 from Davide Cavalca davide@cavalca.name --- This is failing to build for me:
+ /usr/bin/cmake -S . -B redhat-linux-build -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -G Ninja -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF -DROCM_SYMLINK_LIBS=OFF -DHIP_PLATFORM=amd -DBACKEND=HIP '-DAMDGPU_TARGETS=gfx900;gfx906:xnack-;gfx908:xnack-;gfx90a:xnack+;gfx90a:xnack-;gfx942;gfx1010;gfx1012;gfx1030;gfx1100;gfx1101;gfx1102;gfx1103' -DCMAKE_BUILD_TYPE=RelWithDebInfo -DROCM_PATH=/usr -DHIP_PATH=/usr -DCMAKE_INSTALL_LIBDIR=/usr/lib64 -- The CXX compiler identification is unknown -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - failed -- Check for working CXX compiler: /usr/bin/hipcc -- Check for working CXX compiler: /usr/bin/hipcc - broken CMake Error at /usr/share/cmake/Modules/CMakeTestCXXCompiler.cmake:60 (message): The C++ compiler "/usr/bin/hipcc" is not able to compile a simple test program. It fails with the following output: Change Dir: '/builddir/build/BUILD/rocm-rpp-6.2.0-build/rpp-rocm-6.2.0/redhat-linux-build/CMakeFiles/CMakeScratch/TryCompile-ISW6Wl'
Run Build Command(s): /usr/bin/ninja-build -v cmTC_c317b [1/2] /usr/bin/hipcc -O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -Xarch_host -fstack-protector-strong -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -Xarch_host -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -o CMakeFiles/cmTC_c317b.dir/testCXXCompiler.cxx.o -c /builddir/build/BUILD/rocm-rpp-6.2.0-build/rpp-rocm-6.2.0/redhat-linux-build/CMakeFiles/CMakeScratch/TryCompile-ISW6Wl/testCXXCompiler.cxx FAILED: CMakeFiles/cmTC_c317b.dir/testCXXCompiler.cxx.o /usr/bin/hipcc -O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -Xarch_host -fstack-protector-strong -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -Xarch_host -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -o CMakeFiles/cmTC_c317b.dir/testCXXCompiler.cxx.o -c /builddir/build/BUILD/rocm-rpp-6.2.0-build/rpp-rocm-6.2.0/redhat-linux-build/CMakeFiles/CMakeScratch/TryCompile-ISW6Wl/testCXXCompiler.cxx Device not supported - Defaulting to AMD sh: line 1: /usr/bin/clang++: No such file or directory failed to execute:/usr/bin/clang++ -O2 -flto=thin -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS --config /usr/lib/rpm/redhat/redhat-hardened-clang.cfg -Xarch_host -fstack-protector-strong -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -Xarch_host -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -o "CMakeFiles/cmTC_c317b.dir/testCXXCompiler.cxx.o" -c -x hip /builddir/build/BUILD/rocm-rpp-6.2.0-build/rpp-rocm-6.2.0/redhat-linux-build/CMakeFiles/CMakeScratch/TryCompile-ISW6Wl/testCXXCompiler.cxx ninja: build stopped: subcommand failed.
CMake will not be able to correctly generate this project. Call Stack (most recent call first): CMakeLists.txt:32 (project) -- Configuring incomplete, errors occurred!
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #9 from Tom.Rix@amd.com --- /usr/bin/clang++ is part of the current problems with the switch from llvm 18 to llvm 19.
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
--- Comment #10 from Tom.Rix@amd.com --- The clang build issues in rawhide have been resolved, my local fedora-review produces The no gcc or clang is a false positive, rocm packages use hipcc.
- review.txt -
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [ ]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "Apache License 2.0 and/or MIT License", "Public domain", "BSD 3-Clause License". 497 files have unknown license. Detailed output of licensecheck in /sfs/rocm/rpp/review-rocm-rpp/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6025 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: rocm-rpp-6.2.0-1.fc42.x86_64.rpm rocm-rpp-devel-6.2.0-1.fc42.x86_64.rpm rocm-rpp-6.2.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqjci15q1')] checks: 32, packages: 3
rocm-rpp.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 21 filtered, 0 badness; has taken 3.0 s
Rpmlint (debuginfo) ------------------- Checking: rocm-rpp-debuginfo-6.2.0-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyxd_0o8l')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
rocm-rpp.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 22 filtered, 0 badness; has taken 1.0 s
Source checksums ---------------- https://github.com/ROCm/rpp/archive/rocm-6.2.0.tar.gz#/rpp-6.2.0.tar.gz : CHECKSUM(SHA256) this package : 69fbebf50b734e055258ea3c5b0399a51babab8f66074166d2b0fc4f1904c09c CHECKSUM(SHA256) upstream package : 69fbebf50b734e055258ea3c5b0399a51babab8f66074166d2b0fc4f1904c09c
Requires -------- rocm-rpp (rpmlib, GLIBC filtered): libamdhip64.so.6()(64bit) libamdhip64.so.6(hip_4.2)(64bit) libamdhip64.so.6(hip_6.0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libomp.so()(64bit) libomp.so(VERSION)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) rtld(GNU_HASH)
rocm-rpp-devel (rpmlib, GLIBC filtered): librpp.so.1()(64bit) rocm-rpp(x86-64)
Provides -------- rocm-rpp: librpp.so.1()(64bit) rocm-rpp rocm-rpp(x86-64)
rocm-rpp-devel: rocm-rpp-devel rocm-rpp-devel(x86-64)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n rocm-rpp Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, fonts, Python, SugarActivity, PHP, Perl, Ocaml, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #11 from Davide Cavalca davide@cavalca.name --- Verified that it builds now, review looks good, APPROVED. Please fix the soname globbing before importing to be less greedy, e.g. %{_libdir}/librpp.so.1{,.*}
https://bugzilla.redhat.com/show_bug.cgi?id=2259449
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|POST |CLOSED Last Closed| |2024-11-01 16:17:36
--- Comment #12 from Davide Cavalca davide@cavalca.name ---
*** This bug has been marked as a duplicate of bug 2323139 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com