Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
Summary: Review Request: mirage - A fast and simple image viewer Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: fedora-package-review@redhat.com
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mirage... SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mirage... Description: Mirage is a fast and simple GTK+ image viewer. Because it depends only on PyGTK, Mirage is ideal for users who wish to keep their computers lean while still having a clean image viewer.
----------------------------------------------- NOTE:
The original review request is bug 196570 , which is stalled. However, I could not download the original spec file from the bug so I rewrote the spec file fully by myself.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@knox.net.nz
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-18 14:03 EST ------- *** Bug 196570 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From panemade@gmail.com 2006-11-19 02:01 EST ------- Review: + package builds in mock (development i386) for FC7. + rpmlint is silent for RPM and SRPM. + source files match upstream. c87da5b76f856fd7a759a355259b76ed mirage-0.8.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named and is cleanly written. + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc files. + no -devel subpackage exists + no .la files included. + translations are available. + scriptlets update-desktop-database is used. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed successfully + Desktop file is handled correctly in SPEC file. + GUI application + Followed Python packaging guidelines also. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-19 02:04 EST ------- Thank you.
I will import this to FE when FE CVS system revives.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From panemade@gmail.com 2006-11-19 02:07 EST ------- Thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
sundaram@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sundaram@redhat.com
------- Additional Comments From sundaram@redhat.com 2006-11-20 12:59 EST -------
I tried building and running the SRPM package and I get the following traceback.
mirage Traceback (most recent call last): File "/usr/bin/mirage", line 29, in ? app = mirage.Base() File "/usr/lib/python2.4/site-packages/mirage.py", line 270, in __init__ pixbuf = gtk.gdk.pixbuf_new_from_file(leave_fullscreen_icon_path) gobject.GError: Failed to open file '': No such file or directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-20 18:33 EST ------- (In reply to comment #5)
I tried building and running the SRPM package and I get the following traceback.
I cannot figure out what is the problem only from your information. Currently I can only say 'this program works for me'...... Would you tell me more details so that I can reproduce your situation?
By the way, are 3 image files correctly installed under /usr/share/mirage?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From sundaram@redhat.com 2006-11-20 18:52 EST -------
I used rpmbuild to build the srpm at
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mirage....
/usr/share/mirage is empty. Is there any additional details you would like to know?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-20 19:07 EST ------- Created an attachment (id=141711) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141711&action=vie...) rpmbuild build log of mirage-0.8.1-1 by me
(In reply to comment #7)
/usr/share/mirage is empty. Is there any additional details you would like to
know?
This is a problem. Maybe I have to add some BRs (however mockbuild shows no problem for me....) Please attach your build log, which may be helpful.
I attach my build log FYI.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
------- Additional Comments From panemade@gmail.com 2006-11-20 23:21 EST ------- Rahul, Being the reviewer of this package i had checked all things including build.log and tested application successfully by running it from console and desktop icon also. Its working fine without problem in my machine. Can you submit messages coming from following command at least rpmbuild --rebuild mirage-0.8.1-1.src.rpm ?? Also check that you have pygtk2 and gnome-python2-gconf installed on your system. Remember gnome-python2-gconf is in FC6 Updates and not in FC6 Core repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mirage - A fast and simple image viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216282
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-21 04:20 EST ------- Well, * Rebuild for FE-devel succeeded, no problem. http://buildsys.fedoraproject.org/plague-results/fedora-development-extras/m... * SyncNeeded is requested for FE-6, FE-5.
Parag, thank you for reviewing and approving this package!! Rahul, if your problem still reappear, please open a new bug report.
Now I close this bug as CLOSED NEXTRELEASE.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla