https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Bug ID: 1297527 Summary: Review Request: perl-WWW-Twilio-API - Accessing Twilio's REST API with Perl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: denis@fateyev.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API-0.18-1.fc24.src.rpm Description: WWW::Twilio::API aims to make connecting to and making REST calls on the Twilio API easy, reliable, and enjoyable. Fedora Account System Username: dfateyev
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=12499224 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=12498753 (Fedora 23) https://koji.fedoraproject.org/koji/taskinfo?taskID=12499086 (EPEL 7) https://koji.fedoraproject.org/koji/taskinfo?taskID=12499075 (EPEL 6)
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #1 from Petr Šabata psabata@redhat.com --- Question.
32 Requires: perl(LWP::Protocol::https) 33 # perl-libwww-perl in el6 haven't got ssl support by default 34 %{?el6:Requires: perl(Crypt::SSLeay)}
Does this mean that, in EPEL6, HTTPS doesn't work with LWP::Protocol::https?
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #2 from Denis Fateyev denis@fateyev.com --- Right, technically "LWP::Protocol::https" in rhel6 doesn't support HTTPS by default. In more details, "perl(LWP::Protocol::https)" in rhel6 is provided by "perl-libwww-perl" which doesn't require SSL by itself.
# yum whatprovides 'perl(LWP::Protocol::https)' ... perl-libwww-perl-5.833-2.el6.noarch : A Perl interface to the World-Wide Web Repo : base Matched from: Other : perl(LWP::Protocol::https) ... perl-libwww-perl-5.833-2.el6.noarch : A Perl interface to the World-Wide Web Repo : installed Matched from: Other : Provides-match: perl(LWP::Protocol::https)
# rpm -qR perl-libwww-perl /usr/bin/perl mailcap perl >= 0:5.002 perl >= 0:5.004 perl >= 0:5.005 perl(:MODULE_COMPAT_5.10.1) perl(AnyDBM_File) perl(Carp) perl(Compress::Zlib) perl(Digest::MD5) perl(Exporter) perl(Fcntl) perl(File::Listing) perl(Getopt::Long) perl(Getopt::Std) perl(HTML::Entities) perl(HTTP::Cookies) perl(HTTP::Cookies::Netscape) perl(HTTP::Date) perl(HTTP::Headers) perl(HTTP::Headers::Util) perl(HTTP::Message) perl(HTTP::Negotiate) perl(HTTP::Request) perl(HTTP::Response) perl(HTTP::Status) perl(IO::Select) perl(IO::Socket) perl(LWP) perl(LWP::MediaTypes) perl(LWP::MemberMixin) perl(LWP::Protocol) perl(LWP::Protocol::http) perl(LWP::Protocol::http10) perl(LWP::Simple) perl(LWP::UserAgent) perl(MIME::Base64) perl(Net::HTTP) perl(Net::HTTP::Methods) perl(Net::HTTPS) perl(Net::NNTP) perl(Time::Local) perl(URI) perl(URI::Heuristic) perl(URI::URL) perl(WWW::RobotRules) perl(base) perl(integer) perl(locale) perl(strict) perl(vars) perl-HTML-Parser >= 3.33 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1
-------------- A simple practical check:
# yum install 'perl(LWP::Protocol::https)' ... Package perl-libwww-perl-5.833-2.el6.noarch already installed and latest version
# perl -le 'use LWP::UserAgent; my $ua = new LWP::UserAgent; my $request = new HTTP::Request("GET", "https://bugzilla.redhat.com"); my $response = $ua->request($request); print $response->content;' LWP will support https URLs if either Crypt::SSLeay or IO::Socket::SSL is installed. More information at http://search.cpan.org/dist/libwww-perl/README.SSL.
P.S. In rhel7 and fedora it's different: perl(LWP::Protocol::https) is provided by a separate package which requires IO::Socket::SSL.
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #3 from Petr Šabata psabata@redhat.com --- Hrm, okay. perl-libwww-perl's packaging in EL6 could be improved, it seems.
Anyhow, the package is mostly fine. Just...
* You could add the version constraint to that EL6 runtime dependency on Crypt::SSLeay.
* Require version constrained LWP::UserAgent and URI::Escape + filter out the autogenerated underspecified dependencies.
And that's it :)
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- dfateyev's scratch build of perl-WWW-Twilio-API-0.18-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12547493
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #5 from Denis Fateyev denis@fateyev.com --- (In reply to Petr Šabata from comment #3)
Hrm, okay. perl-libwww-perl's packaging in EL6 could be improved, it seems.
It would be good, but I doubt they would do it now with rhel6.
You could add the version constraint to that EL6 runtime dependency on Crypt::SSLeay.
Require version constrained LWP::UserAgent and URI::Escape + filter out the autogenerated underspecified dependencies.
Done. The updated version: Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API-0.18-2.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Petr Šabata psabata@redhat.com --- Acking changes and approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-WWW-Twilio-API
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7eef5cd0bf
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7eef5cd0bf
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d6a91da2e
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d6a91da2e
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a21b459a4e
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7eef5cd0bf
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a21b459a4e
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2807c20ee4
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0d6a91da2e
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-01-24 17:50:20
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1297527
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-WWW-Twilio-API-0.18-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org