[Bug 440246] New: Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=440246

Summary: Review Request: firecontrol -  A console oriented tool
                    for Linux to access a FireWire bus
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://people.redhat.com/jwilson/packages/firecontrol/firecontrol.spec
SRPM URL: http://people.redhat.com/jwilson/packages/firecontrol/firecontrol-0.2-1.fc9....

Description:
FireControl, the IEEE 1394 Commander, is a console oriented tool for Linux
to access an IEEE 1394 (FireWire) bus. It can issue asynchronous read, write
and lock requests to some nodes on the bus, force bus resets, and send PHY
packets. Furthermore, it provides bus reset notifications. The main advantage
of this tool over other available tools (like gscanbus) is (besides not
requiring a graphical interface) that it reports the exact acknowledge and
response codes and, therefore, is very useful for debugging purposes.

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

------- Additional Comments From [e-mail]  2008-04-03 23:03 EST -------
Builds fine and rpmlint finds nothing to complain about.

According to the source (or commander.c, at least), the license is GPLv2+.  Do
you see anything that might restrict it to GPLv2 only?

Everything else looks good to me.

* source files match upstream:
   415e3e257472c3f784eba43d0c298d2432491b20870f0cbe6beb6756692235f8  
   firecontrol-0.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   firecontrol = 0.2-1.fc9
  =
   libraw1394.so.8()(64bit)

* %check is not present; no test suite upstream.  I have no way to test this 
  software.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

------- Additional Comments From [e-mail]  2008-04-03 23:38 EST -------
Oops, I'd only looked at the COPYING file and saw it was GPLv2, neglected to
look at the source header to see 2+ there. I'll fix that. Okay, done:

http://people.redhat.com/jwilson/packages/firecontrol/firecontrol-0.2-2.fc9....
http://people.redhat.com/jwilson/packages/firecontrol/firecontrol.spec

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

------- Additional Comments From [e-mail]  2008-04-03 23:42 EST -------
Oh, and to test it, simply start it up with elevated privs on a box with a
firewire controller. It should report number of controllers found, current bus
generation, etc. You can try issuing the command 'br short' to see if it
properly issues a bus reset to the controller or 'r . 0 0xfffff0000400 4' to
read the first quadlet of the card's config rom, which is some header CRC and
length info, or offset 404, which is the 1394 header. For example:
...
Command: r . 0 0xfffff0000400 4
reading from node 0, bus 1023, offset 0XFFFFF0000400 4 bytes
read succeeded. Data follows (hex):
04 04 22 8E
Ack code: complete
Command: r . 0 0xfffff0000404 4
reading from node 0, bus 1023, offset 0XFFFFF0000404 4 bytes
read succeeded. Data follows (hex):
31 33 39 34
Ack code: complete

It gets far more interesting with devices connected, of course.

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-04-03 23:48 EST -------
Cool.  I went ahead and built it for i386 and ran it on a rawhide box with a
firewire port.  It did indeed seem to work fine with the above examples.

APPROVED

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-04-04 12:18 EST -------
tibbs, thanks much for the review!

New Package CVS Request
=======================
Package Name: firecontrol
Short Description: A console oriented tool for Linux to access a FireWire bus
Owners: jwilson
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-04-04 13:02 EST -------
cvs done.

[Bug 440246] Review Request: firecontrol - A console oriented tool for Linux to access a FireWire bus

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firecontrol -  A console oriented tool for Linux to access a FireWire bus

https://bugzilla.redhat.com/show_bug.cgi?id=440246

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-04-04 14:21 EST -------
Built.