[Bug 1874058] New: Review Request: logiops - Unofficial driver for Logitech mice and keyboard
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
Bug ID: 1874058 Summary: Review Request: logiops - Unofficial driver for Logitech mice and keyboard Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: deamicis@bluewin.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://deamn.fedorapeople.org/logiops.spec SRPM URL: https://deamn.fedorapeople.org/logiops-0.2.2-1.fc32.src.rpm Description: This is an unofficial driver for Logitech mice and keyboard.
This is currently only compatible with HID++ >2.0 devices.
Fedora Account System Username: deamn
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Iwicki fedora@svgames.pl ---
%global logiops %{name}
What's this for?
Source0: https://github.com/PixlOne/logiops/archive/6d7d91c.zip
The project seems to mark releases with git tags. You can fetch a specific tag from GitHub. Switch the Source URL to: https://github.com/PixlOne/logiops/archive/%%7Bversion%7D/logiops-%%7Bversio...
ExclusiveArch: x86_64
Why? I took a brief peek at the GitHub repo and didn't see anything saying that it won't work on other architectures.
%global debug_package %{nil}
This is generally a red flag. We want debuginfo in Fedora packages. Remove this.
mkdir build cd build cmake ..
Use the %{cmake} macro instead. It will handle setting up CXXFLAGS (which should enable debuginfo generation) and also create the build directory ("%{__cmake_builddir}").
cd build make
Use %{cmake_build} instead.
install -d -m 755 %{buildroot}%{_bindir} cp -a build/logid %{buildroot}%{_bindir} install -d -m 755 %{buildroot}%{_exec_prefix}/lib/systemd/system/ cp -a build/logid.service %{buildroot}%{_exec_prefix}/lib/systemd/system/
Try using %{cmake_install} instead?
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
--- Comment #2 from Nicolas De Amicis deamicis@bluewin.ch --- Thanks for the review.
I made the changes. Could you please review the package again?
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - BR systemd-rpm-macros
- %{_exec_prefix}/lib/systemd/system/logid.service → %{_unitdir}/logid.service
- Add the systemd scriptlets. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_syste...
%post %systemd_post logid.service
%preun %systemd_preun logid.service
%postun %systemd_postun_with_restart logid.service
- License: GPL v3 → License: GPLv3
- %{cmake} call should be at the beginning of %build, not in %prep
- Use a more specific name for your archive. Also we usually work with tar.gz in Linux
Source0: https://github.com/PixlOne/logiops/archive/v%%7Bversion%7D.zip
→
Source0: https://github.com/PixlOne/logiops/archive/v%%7Bversion%7D/%%7Bname%7D-%%7Bv...
- Please add your email to your changelog entry:
* Mon Aug 31 2020 Nicolas De Amicis deamicis@bluewin.ch - 0.2.2-1
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
--- Comment #4 from Nicolas De Amicis deamicis@bluewin.ch --- Thanks Robert-André, I modified the spec file as requested.
Could you review again :-) ?
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Don't mix tabs and spaces:
logiops.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7)
There a tab after the URL: field.
Package approved, please fix the issue before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later". 10 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/logiops/review-logiops/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in logiops [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: logiops-0.2.2-1.fc34.x86_64.rpm logiops-debuginfo-0.2.2-1.fc34.x86_64.rpm logiops-debugsource-0.2.2-1.fc34.x86_64.rpm logiops-0.2.2-1.fc34.src.rpm logiops.x86_64: W: no-manual-page-for-binary logid logiops.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7) 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/logiops
https://bugzilla.redhat.com/show_bug.cgi?id=1874058
Nicolas De Amicis deamicis@bluewin.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2020-09-02 10:10:15
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com