[Bug 1178687] New: Review Request: python-glob2 - Glob module recursive wildcards support
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Bug ID: 1178687 Summary: Review Request: python-glob2 - Glob module recursive wildcards support Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jujens@jujens.eu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-glob2.spec SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-glob2-0.4.1... Description: Version of the glob module that can capture patterns and supports recursive wildcards. Fedora Account System Username: jujens
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Looks good.
I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict.
There's no license file. Please ping upstream and add a comment in the spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- $ rpmlint python-glob2 python-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters python-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint python3-glob2 python3-glob2.noarch: W: spelling-error Summary(en_US) wildcards -> wild cards, wild-cards, wildcatters python3-glob2.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Yes, package is OK as is, even before the cleanups from #c1. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
--- Comment #3 from Julien Enselme jujens@jujens.eu --- The license was added upstream some time ago: https://github.com/miracle2k/python-glob2/blob/master/LICENSE It is just not included in any release yet.
I think you can simplify the spec by not creating a separate build dir for python3. All that the "build" does is copy the .py files and generate .py[co], and .py[co] files for Python 2 and 3 are in different directories, so there's no conflict.
Maybe, but I am used to this method now and it is what I saw in the wiki: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file.
Thanks for your review!
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Julien Enselme jujens@jujens.eu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Julien Enselme jujens@jujens.eu --- New Package SCM Request ======================= Package Name: python-glob2 Short Description: Glob module recursive wildcards support Upstream URL: https://pypi.python.org/pypi/glob2 Owners: jujens Branches: fc20 fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-glob2-0.4.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-glob2-0.4.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-glob2-0.4.1-2.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- Package python-glob2-0.4.1-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-glob2-0.4.1-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-1221/python-glob2-0.4.1-... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-glob2-0.4.1-2.fc20 Resolution|--- |ERRATA Last Closed| |2015-02-04 02:56:15
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-glob2-0.4.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1178687
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-glob2-0.4.1-2.fc20 |python-glob2-0.4.1-2.fc21
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-glob2-0.4.1-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla