[Bug 860703] New: Review Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

            Bug ID: 860703
        QA Contact: extras-qa(a)fedoraproject.org
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
          Assignee: nobody(a)fedoraproject.org
           Summary: Review Request: tmw-music - Music files for The Mana
                    World
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: martin.gieseking(a)uos.de
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL: http://mgieseki.fedorapeople.org/review/tmw-music.spec
SRPM URL: http://mgieseki.fedorapeople.org/review/tmw-music-0.3-5.fc17.src.rpm

Description: 
This package contains the optional music files for The Mana World (TMW).

Additional information:
tmw-music is supposed to replace manaworld-music, an optional music package for
manaworld. manaworld is going to be replaced with tmw because of file
conflicts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Review Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Martin Gieseking <martin.gieseking(a)uos.de&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |860697

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Review Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Martin Gieseking <martin.gieseking(a)uos.de&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |tmw-music

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Martin Gieseking <martin.gieseking(a)uos.de&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: tmw-music - |Rename Request: tmw-music -
                   |Music files for The Mana    |Music files for The Mana
                   |World                       |World

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Mario Blättermann <mario.blaettermann(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann(a)gmail.co
                   |                            |m
           Assignee|nobody(a)fedoraproject.org    |mario.blaettermann(a)gmail.co
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #1 from Mario Blättermann <mario.blaettermann(a)gmail.com&gt; ---
Taking this for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Mario Blättermann <mario.blaettermann(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #2 from Mario Blättermann <mario.blaettermann(a)gmail.com&gt; ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4558266

$ rpmlint -i -v *
tmw-music.src: I: checking
tmw-music.src: I: checking-url http://themanaworld.org (timeout 10 seconds)
tmw-music.src: I: checking-url
http://downloads.sourceforge.net/themanaworld/TMW%20Music/0.3/tmwmusic-0....
(timeout 10 seconds)
tmw-music.noarch: I: checking
tmw-music.noarch: I: checking-url http://themanaworld.org (timeout 10 seconds)
tmw-music.noarch: E: incorrect-fsf-address /usr/share/doc/tmw-music-0.3/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

tmw-music.spec: I: checking-url
http://downloads.sourceforge.net/themanaworld/TMW%20Music/0.3/tmwmusic-0....
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

No issues so far. As usual, don't touch the license file, but please inform the
upstream folks about the wrong FSF address.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
    GPLv2
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
    $ sha256sum *
    9c942b0f9a9a3692f2a0c80b0a7433d7b0adaa35e6c85eab26723299b6c9c4bb 
tmwmusic-0.3.tar.gz
    9c942b0f9a9a3692f2a0c80b0a7433d7b0adaa35e6c85eab26723299b6c9c4bb 
tmwmusic-0.3.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[.] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.

----------------

PACKAGE APPROVED

----------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Martin Gieseking <martin.gieseking(a)uos.de&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #3 from Martin Gieseking <martin.gieseking(a)uos.de&gt; ---
Great. Thank you for the immediate review. Upstream is already informed about
the license issue, and will hopefully fix it shortly.


New Package SCM Request
=======================
Package Name: tmw-music
Short Description: Music files for The Mana World
Owners: mgieseki
Branches: f16 f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #4 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
tmw-music-0.3-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
tmw-music-0.3-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
tmw-music-0.3-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tmw-music-0.3-5.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
tmw-music-0.3-5.fc17 has been pushed to the Fedora 17 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Bug 860703 depends on bug 860697, which changed state.

Bug 860697 Summary: Review Request: tmw - The Mana World is a 2D MMORPG
https://bugzilla.redhat.com/show_bug.cgi?id=860697

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |NEXTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=860703

Mario Blättermann <mario.blaettermann(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2012-11-21 15:23:46

--- Comment #9 from Mario Blättermann <mario.blaettermann(a)gmail.com&gt; ---
All packages are marked as stable now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 860703] Rename Request: tmw-music - Music files for The Mana World

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=860703

Raphael Groner <projects.rg(a)smart.ms&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |projects.rg(a)smart.ms
              Alias|tmw-music                   |



--- Comment #10 from Raphael Groner <projects.rg(a)smart.ms&gt; ---
Removing alias to allow general search for bugs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component