[Bug 911056] New: Review Request: nodejs-underscore-logger - Cross-browser and Node.js empowered logging
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911056
Bug ID: 911056 Summary: Review Request: nodejs-underscore-logger - Cross-browser and Node.js empowered logging Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jamielinux@fedoraproject.org
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-logge... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore... Fedora Account System Username: jamielinux
Description: Cross-browser and Node.js empowered logging.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911056
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |911022
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911056
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #1 from Jamie Nguyen jamielinux@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-logge... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore...
* Sun Feb 17 2013 Jamie Nguyen jamielinux@fedoraproject.org - 0.3.1-2 - add coffee-script to BuildRequires
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #2 from Jamie Nguyen jamielinux@fedoraproject.org --- Fix links:
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-logge... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore...
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
--- Comment #3 from Tom Hughes tom@compton.nu ---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
[!]: Package complies to the Packaging Guidelines
lib/underscore.logger.js should be rebuilt from src/underscore.logger.coffee
[!]: Package is named according to the Package Naming Guidelines.
Should it be underscore-dot-logger as with expect-dot-js? Not sure what led to the name change from expect-js to expect-dot-js?
[!]: %check is present and all tests pass.
The tests themselves are fine, but because package.json does not declare the devDependencies the %nodejs_symlink_deps call is not able to setup node_modules correctly.
Also npm(underscore) is needed for the tests.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-underscore-logger-0.3.1-2.fc20.noarch.rpm nodejs-underscore-logger.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-underscore-logger.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-underscore-logger.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-underscore-logger nodejs-underscore-logger.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-underscore-logger.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-underscore-logger.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-underscore-logger (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-underscore-logger: nodejs-underscore-logger npm(underscore.logger)
Source checksums ---------------- http://registry.npmjs.org/underscore.logger/-/underscore.logger-0.3.1.tgz : CHECKSUM(SHA256) this package : 4d2fa0390f77d3569391eadd052963af3e15608abd55a52b3684f79389aec929 CHECKSUM(SHA256) upstream package : 4d2fa0390f77d3569391eadd052963af3e15608abd55a52b3684f79389aec929
Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 911056
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |nodejs-underscore-logger - |nodejs-underscore-dot-logge |Cross-browser and Node.js |r - Cross-browser and |empowered logging |Node.js empowered logging
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #4 from Jamie Nguyen jamielinux@fedoraproject.org --- (In reply to Tom Hughes from comment #3)
[!]: Package is named according to the Package Naming Guidelines.
Should it be underscore-dot-logger as with expect-dot-js? Not sure what led to the name change from expect-js to expect-dot-js?
Thanks, I've renamed. The reason for expect-js -> expect-dot-js is because if a module is introduced into the npm registry called "expect-js" then we'll have a name conflict.
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-dot-l... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore...
* Fri Jul 12 2013 Jamie Nguyen jamielinux@fedoraproject.org - 0.3.1-3 - rename to nodejs-underscore-dot-logger - add patch for missing devDependencies - add patch for newer coffee-script version JS compliance requirements - add patch for building using the Cakefile
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #5 from Tom Hughes tom@compton.nu --- The \033 should be \x1b surely? It's supposed to be an escape character, ascii 27.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #6 from Tom Hughes tom@compton.nu --- Oh, and the BR for coffee-script will need to be outside of the enable_tests block as it's used for the build now.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #7 from Jamie Nguyen jamielinux@fedoraproject.org --- Oops, not sure how I overlooked that...
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-dot-l... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore...
* Fri Jul 12 2013 Jamie Nguyen jamielinux@fedoraproject.org - 0.3.1-4 - fix patch for JS compliance - fix BR
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from Tom Hughes tom@compton.nu --- The rm of "lib/*.coffee" in %setup isn't actually doing anything - assume you meant "lib/*.js" instead? It still rebuilds anyway.
Other than that it all looks good, so package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #9 from Jamie Nguyen jamielinux@fedoraproject.org --- (In reply to Tom Hughes from comment #8)
The rm of "lib/*.coffee" in %setup isn't actually doing anything - assume you meant "lib/*.js" instead? It still rebuilds anyway.
Hmm, I remember noticing that mistake and fixing it, but my brain must be failing me today.
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore-dot-l... SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore...
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-underscore-dot-logger Short Description: Cross-browser and Node.js empowered logging Owners: jamielinux patches Branches: f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-underscore-dot-logger-0.3.1-5...
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-underscore-dot-logger-0.3.1-5...
https://bugzilla.redhat.com/show_bug.cgi?id=911056
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-underscore-dot-logger-0.3.1-5...
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.el6 has been pushed to the Fedora EPEL 6 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-07-17 17:30:38
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-underscore-dot-logge | |r-0.3.1-5.fc19
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-underscore-dot-logge |nodejs-underscore-dot-logge |r-0.3.1-5.fc19 |r-0.3.1-5.fc18
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=911056
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-underscore-dot-logge |nodejs-underscore-dot-logge |r-0.3.1-5.fc18 |r-0.3.1-5.el6
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- nodejs-underscore-dot-logger-0.3.1-5.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla