https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Bug ID: 1722621 Summary: Review Request: pypykatz - A Python implementation of Mimikatz Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/pypykatz.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/pypykatz-0.0.7-1.fc30.src.rpm
Project URL: https://github.com/skelsec/pypykatz
Description: Mimikatz implementation in pure Python. It's optimized for offline parsing, but has options for live credential dumping as well.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35658287
rpmlint output: $ rpmlint pypykatz-0.0.7-1.fc30.src.rpm pypykatz.src: W: spelling-error %description -l en_US Mimikatz -> Kamikaze 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint *pypykatz* pypykatz.noarch: W: spelling-error %description -l en_US Mimikatz -> Kamikaze pypykatz.noarch: W: no-manual-page-for-binary pypykatz 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |563471 (FE-SECLAB) Alias| |pypykatz
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1722597, 1722614
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1722597 [Bug 1722597] Review Request: python-minikerberos - A Kerberos manipulation library in Python https://bugzilla.redhat.com/show_bug.cgi?id=1722614 [Bug 1722614] Review Request: python-minidump - A Python library to parse and read Microsoft minidump file format
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated", "BSD 2-clause "Simplified" License", "BSD 3-clause "New" or "Revised" License". 46 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/pypykatz/review-pypykatz/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: pypykatz-0.0.7-1.fc31.noarch.rpm pypykatz-0.0.7-1.fc31.src.rpm pypykatz.noarch: W: spelling-error %description -l en_US Mimikatz -> Kamikaze pypykatz.noarch: W: no-manual-page-for-binary pypykatz pypykatz.src: W: spelling-error %description -l en_US Mimikatz -> Kamikaze pypykatz.src:24: W: macro-in-comment %{pypi_name} 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for the review and have a nice weekend.
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pypykatz
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-ae0b2d780f has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae0b2d780f
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- pypykatz-0.0.7-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ae0b2d780f
https://bugzilla.redhat.com/show_bug.cgi?id=1722621 Bug 1722621 depends on bug 1722614, which changed state.
Bug 1722614 Summary: Review Request: python-minidump - A Python library to parse and read Microsoft minidump file format https://bugzilla.redhat.com/show_bug.cgi?id=1722614
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1722621 Bug 1722621 depends on bug 1722597, which changed state.
Bug 1722597 Summary: Review Request: python-minikerberos - A Kerberos manipulation library in Python https://bugzilla.redhat.com/show_bug.cgi?id=1722597
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1722621
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-07-03 01:16:35
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- pypykatz-0.0.7-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com