https://bugzilla.redhat.com/show_bug.cgi?id=1446927
Bug ID: 1446927 Summary: Review Request: rubygem-native-package-installer - Native packages installation helper Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mtasaka@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-native-p...
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-native-p...
Description: Users need to install native packages to install an extension library that depends on native packages. It bores users because users need to install native packages and an extension library separately. native-package-installer helps to install native packages on "gem install". Users can install both native packages and an extension library by one action, "gem install".
Fedora Account System Username: mtasaka
Koji scratch build: F-27: https://koji.fedoraproject.org/koji/taskinfo?taskID=19324908 F-26: https://koji.fedoraproject.org/koji/taskinfo?taskID=19324905
https://bugzilla.redhat.com/show_bug.cgi?id=1446927
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |valtri@civ.zcu.cz Assignee|nobody@fedoraproject.org |valtri@civ.zcu.cz Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1446927
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from František Dvořák valtri@civ.zcu.cz --- Some cosmetics/questions:
* Package contains BuildRequires: ruby(release)
It is probably not needed? But it's OK - guidelines doesn't mention nor discourage it and it is generated by gem2rpm.
* New version 1.0.1 has been released right now
* Function is OK
ruby -rnative-package-installer -e 'p NativePackageInstaller::ExecutableFinder::new("service").find'
Package APPROVED!
https://bugzilla.redhat.com/show_bug.cgi?id=1446927
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- Okay, thank you! I will update version later.
https://bugzilla.redhat.com/show_bug.cgi?id=1446927
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-native-package-in...
https://bugzilla.redhat.com/show_bug.cgi?id=1446927
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |rubygem-native-package-inst | |aller-1.0.1-1.fc27 Resolution|--- |NEXTRELEASE Last Closed| |2017-05-03 11:20:21
--- Comment #4 from Mamoru TASAKA mtasaka@fedoraproject.org --- Thank you for review! Closing.
package-review@lists.fedoraproject.org