[Bug 1246177] New: Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

Bug ID: 1246177
           Summary: Review Request: libgsasl - Reenable GSSAPI support
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: <spec info here>
SRPM URL:
http://people.redhat.com/~pbelange/fedora-review/libgsasl-1.8.0-6.fc24.src.r...
Description: Since Fedora 18, GSSAPI support has been missing from libgsasl.
> From the looks of it the configure script changed in version 1.8.0, not

detecting the system libraries.

Now, we explicitly pass the flags to enable GSSAPI support.
Fedora Account System Username: pabelanger

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #1 from Paul Belanger  ---
Sorry, clicked submit too soon

Spec URL:
http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl.spec
SRPM URL:
http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl-1.8.0-6.fc...
Description: Since Fedora 18, GSSAPI support has been missing from libgsasl.
> From the looks of it the configure script changed in version 1.8.0, not

detecting the system libraries.

Now, we explicitly pass the flags to enable GSSAPI support.
Fedora Account System Username: pabelanger

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

Paul Belanger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1134957

--- Comment #2 from Paul Belanger  ---
Sorry, clicked submit too soon

Spec URL:
http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl.spec
SRPM URL:
http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl-1.8.0-6.fc...
Description: Since Fedora 18, GSSAPI support has been missing from libgsasl.
> From the looks of it the configure script changed in version 1.8.0, not

detecting the system libraries.

Now, we explicitly pass the flags to enable GSSAPI support.
Fedora Account System Username: pabelanger

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #3 from Paul Belanger  ---
Not sure what happen on the double post. Really noobed things up here.

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #4 from Paul Belanger  ---
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10450050

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #5 from Paul Belanger  ---
$ rpmlint libgsasl-1.8.0-6.fc24.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint libgsasl.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #6 from Michael Schwendt (Fedora Packager Sponsors Group)  ---
> %package        devel
> Requires:       pkgconfig

There's an automatic dependency on /usr/bin/pkgconfig and there are automatic
pkgconfig(…) Provides for .pc file inter-dependencies, too. That applies to all
current Fedora releases as well as RHEL 6.
> %files -f %{name}.lang
> %doc AUTHORS COPYING NEWS README THANKS
> %files devel
> %doc COPYING

There is the special %license macro since early 2015:

https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing
  -> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Plus, you don't need to duplicate the COPYING file in the -devel subpackage,
because that one depends on the base package already:

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Lice...

[Bug 1246177] Review Request: libgsasl - Reenable GSSAPI support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #7 from Paul Belanger  ---
Michael,

Thanks for the review. I wanted to actually show the diff of my patchset that I
didn't link in the original post (see below).

I don't mind submitting a follow up patchs to address the existing packaging
issues that you raise, however my current patchs really just toggles the build
flags.

---
diff --git a/libgsasl.spec b/libgsasl.spec
index d77ed02..fb322a6 100644
--- a/libgsasl.spec
+++ b/libgsasl.spec
@@ -31,7 +31,7 @@ developing applications that use %{name}.
 %setup -q

%build
-%configure --disable-static --disable-rpath
+%configure --disable-static --disable-rpath --with-gssapi-impl=mit
 make %{?_smp_mflags}

%install
@@ -54,6 +54,9 @@ find %{buildroot} -name '*.la' -exec rm -f {} ';'
 %{_libdir}/pkgconfig/libgsasl.pc

%changelog
+* Wed Jul 22 2015 Paul Belanger  - 1.8.0-7
+- Re-enable GSSAPI support (#1134957)
+
 * Wed Jun 17 2015 Fedora Release Engineering 
- 1.8.0-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild

[Bug 1246177] libgsasl: reenable gssapi support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
          Component|Package Review              |libgsasl
           Assignee|[e-mail]    |[e-mail]
            Summary|Review Request: libgsasl -  |libgsasl: reenable gssapi
                   |Reenable GSSAPI support     |support

--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
My rephrasing of the orignal bug report:

Package is built with gssapi support because configure is not finding the
implementation. Please add --with-gssapi-impl=mit to ./configure flags.

[Bug 1246177] libgsasl: reenable gssapi support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #9 from Paul Belanger  ---
Anything I can do to get this landed?

[Bug 1246177] libgsasl: reenable gssapi support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

--- Comment #10 from Peter Lemenkov  ---
(In reply to Paul Belanger from comment #9)
> Anything I can do to get this landed?

Hello, Paul. I've just added you as a co-maintainer. Sorry for the delay.

[Bug 1246177] libgsasl: reenable gssapi support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Peter Lemenkov  ---
*** Bug 1134957 has been marked as a duplicate of this bug. ***

[Bug 1246177] libgsasl: reenable gssapi support

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246177

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-02-08 08:07:41