[Bug 2214434] New: Review Request: rust-prometheus-client-derive-encode - Auxiliary crate to derive Encode trait from prometheus-client
8:17 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Bug ID: 2214434
Summary: Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from
prometheus-client
Product: Fedora
Version: rawhide
Status: NEW
Component: Package Review
Assignee: nobody(a)fedoraproject.org
Reporter: decathorpe(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://decathorpe.fedorapeople.org/rust-prometheus-client-derive-encode....
SRPM URL:
https://decathorpe.fedorapeople.org/rust-prometheus-client-derive-encode-...
Description:
Auxiliary crate to derive Encode trait from prometheus-client.
Fedora Account System Username: decathorpe
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
8:17 p.m.
New subject: [Bug 2214434] Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from prometheus-client
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
This package built on koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=102080077
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:54 p.m.
New subject: [Bug 2214434] Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from prometheus-client
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
blinxen <h-k-81(a)hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |h-k-81(a)hotmail.com
Assignee|nobody(a)fedoraproject.org |h-k-81(a)hotmail.com
Flags| |fedora-review+
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
--- Comment #2 from blinxen <h-k-81(a)hotmail.com> ---
Taking this review
General comments:
- Package was generated with rust2rpm and some changes were made
- Tests were deactivated because of missing files in the published crate -->
should be OK
- License files are not published in the crate and are installed separately
--> Reporting / fixing this upstream would be good
APPROVED
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 5 files have unknown license. Detailed
output of licensecheck in /var/lib/copr-rpmbuild/results/rust-
prometheus-client-derive-encode/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
prometheus-client-derive-encode-devel , rust-prometheus-client-derive-
encode+default-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: rust-prometheus-client-derive-encode-devel-0.4.1-1.fc38.noarch.rpm
rust-prometheus-client-derive-encode+default-devel-0.4.1-1.fc38.noarch.rpm
rust-prometheus-client-derive-encode-0.4.1-1.fc38.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_5cd3fk0')]
checks: 31, packages: 3
rust-prometheus-client-derive-encode+default-devel.noarch: W: no-documentation
rust-prometheus-client-derive-encode-devel.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken
0.1 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2
rust-prometheus-client-derive-encode+default-devel.noarch: W: no-documentation
rust-prometheus-client-derive-encode-devel.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken
0.0 s
Source checksums
----------------
https://github.com/prometheus/client_rust/raw/v0.19.0/LICENSE-MIT :
CHECKSUM(SHA256) this package :
0fd830000a45d0c472e06b2a3718b070c902ee9a71a6abc1647ce66920de2eb5
CHECKSUM(SHA256) upstream package :
0fd830000a45d0c472e06b2a3718b070c902ee9a71a6abc1647ce66920de2eb5
https://github.com/prometheus/client_rust/raw/v0.19.0/LICENSE-APACHE :
CHECKSUM(SHA256) this package :
2f1947dc952374ef4bf326c7c576a0287fb10a8c069dc6bdef981a7ea0a0cf1a
CHECKSUM(SHA256) upstream package :
2f1947dc952374ef4bf326c7c576a0287fb10a8c069dc6bdef981a7ea0a0cf1a
https://crates.io/api/v1/crates/prometheus-client-derive-encode/0.4.1/dow...
:
CHECKSUM(SHA256) this package :
72b6a5217beb0ad503ee7fa752d451c905113d70721b937126158f3106a48cc1
CHECKSUM(SHA256) upstream package :
72b6a5217beb0ad503ee7fa752d451c905113d70721b937126158f3106a48cc1
Requires
--------
rust-prometheus-client-derive-encode-devel (rpmlib, GLIBC filtered):
(crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) <
2.0.0~)
(crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0~)
(crate(syn/default) >= 1.0.0 with crate(syn/default) < 2.0.0~)
cargo
rust-prometheus-client-derive-encode+default-devel (rpmlib, GLIBC filtered):
cargo
crate(prometheus-client-derive-encode)
Provides
--------
rust-prometheus-client-derive-encode-devel:
crate(prometheus-client-derive-encode)
rust-prometheus-client-derive-encode-devel
rust-prometheus-client-derive-encode+default-devel:
crate(prometheus-client-derive-encode/default)
rust-prometheus-client-derive-encode+default-devel
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
rust-prometheus-client-derive-encode --mock-config
/var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-38-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Python, C/C++, PHP, R, Perl, Haskell, SugarActivity, Ocaml,
fonts, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:58 p.m.
New subject: [Bug 2214434] Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from prometheus-client
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
--- Comment #3 from Fabio Valentini <decathorpe(a)gmail.com> ---
Thanks for the review!
--> Reporting / fixing this upstream would be good
Yeah, looks like I forgot to do this for this crate. I'll take care of that
later.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:59 p.m.
New subject: [Bug 2214434] Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from prometheus-client
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
--- Comment #4 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-prometheus-client-derive-encode
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
2:33 p.m.
New subject: [Bug 2214434] Review Request: rust-prometheus-client-derive-encode -
Auxiliary crate to derive Encode trait from prometheus-client
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Fixed In Version| |rust-prometheus-client-deri
| |ve-encode-0.4.1-1.fc39
Resolution|--- |RAWHIDE
Last Closed| |2023-07-06 19:33:41
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1769513dbd
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2214434
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
333
days inactive
356
days old
package-review@lists.fedoraproject.org
5 comments
1 participants
participants (1)
-
bugzilla＠redhat.com