Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Summary: Review Request: kde-plasma-kprayertime - Displays Islamic prayer Time Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: imranceh@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://github.com/downloads/matriux/fedora/kde-plasma-kprayertime.spec SRPM URL: http://github.com/downloads/matriux/fedora/kde-plasma-kprayertime-4.01-1.fc1... Description: Plasmoid to display Islamic Prayer time
rpmlint ======== [imran@localhost SPECS]$ rpmlint kde-plasma-kprayertime.spec ../SRPMS/kde-plasma-kprayertime-4.01-1.fc12.src.rpm ../RPMS/i686/kde-plasma-kprayertime-4.01-1.fc12.i686.rpm
kde-plasma-kprayertime.src: W: spelling-error %description -l en_US Plasmoid -> Plasma, Plastic, Plasticine
kde-plasma-kprayertime.i686: W: spelling-error %description -l en_US Plasmoid -> Plasma, Plastic, Plasticine
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #1 from Volker Fröhlich volker27@gmx.at 2010-11-27 17:08:04 EST --- * rpmlint clean
* sources: OK $ md5sum kprayertime4.01.src.tar.gz 098682e4b6c6b5b1f5caf68f4d3ca412 kprayertime4.01.src.tar.gz
* license ok
* builds on F13, F14 and Rawhide
* installs/runs ok
* files ok
I'm not really sure, if upstream calls it kde-plasma-kprayertime or kde-plasma-kprayertime4.
I think it is prefered to write "BuildRequires: cmake gettext" instead of "BuildRequires: cmake,gettext". Your package doesn't seem to need gettext, since no translations are included.
I think the description should end with a period. The capitalization of "Islamic Prayer time" is also different for the description and the summary.
You may have to add these two lines, since your package introduces a shared library.
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2010-11-30 11:32:59 EST --- Just a note that the .so file is not in the regular library path and calling ldconfig is superfluous.
See http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries: " In addition, every binary RPM package which contains shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig [...] "
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |volker27@gmx.at
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
--- Comment #3 from Volker Fröhlich volker27@gmx.at 2011-01-12 05:37:16 EST --- Are you still interested in packaging this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |StalledSubmitter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG Last Closed| |2011-04-15 15:29:40
--- Comment #4 from Volker Fröhlich volker27@gmx.at 2011-04-15 15:29:40 EDT --- Re-open if necessary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604031
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Blocks|656997(kde-reviews) |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla