Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Bug ID: 918612 Summary: Review Request: perl-HTML-Element-Extended - Various HTML::Element extensions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: psabata@redhat.com
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-HTML-Element-Extended/perl-HTML-El... SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-HTML-Element-Extended/perl-HTML-El... Description: This package contains various extensions for HTML::Element. Fedora Account System Username: psabata
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |914285
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source file is original (SHA-256: f3ef1af108f27fef15ebec66479f251ce08aa49bd00b0462c9c80c86b4b6b32b). Summary is good. Ok. Description is good. Ok. License verified from README, lib/HTML/ElementRaw.pm, lib/HTML/ElementTable.pm, lib/HTML/ElementGlob.pm, lib/HTML/ElementSuper.pm. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok.
$ rpmlint perl-HTML-Element-Extended.spec ../SRPMS/perl-HTML-Element-Extended-1.18-1.fc19.src.rpm ../RPMS/noarch/perl-HTML-Element-Extended-1.18-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-HTML-Element-Extended-1.18-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Mar 7 13:13 /usr/share/doc/perl-HTML-Element-Extended-1.18 -rw-r--r-- 1 root root 2702 Jun 10 2010 /usr/share/doc/perl-HTML-Element-Extended-1.18/Changes -rw-r--r-- 1 root root 1822 Mar 9 2005 /usr/share/doc/perl-HTML-Element-Extended-1.18/README -r--r--r-- 1 root root 2985 Mar 7 13:13 /usr/share/man/man3/HTML::ElementGlob.3pm.gz -r--r--r-- 1 root root 2478 Mar 7 13:13 /usr/share/man/man3/HTML::ElementRaw.3pm.gz -r--r--r-- 1 root root 3898 Mar 7 13:13 /usr/share/man/man3/HTML::ElementSuper.3pm.gz -r--r--r-- 1 root root 4815 Mar 7 13:13 /usr/share/man/man3/HTML::ElementTable.3pm.gz drwxr-xr-x 2 root root 0 Mar 7 13:13 /usr/share/perl5/vendor_perl/HTML -r--r--r-- 1 root root 8093 Jun 9 2010 /usr/share/perl5/vendor_perl/HTML/ElementGlob.pm -r--r--r-- 1 root root 2581 Jun 9 2010 /usr/share/perl5/vendor_perl/HTML/ElementRaw.pm -r--r--r-- 1 root root 18092 Jun 9 2010 /usr/share/perl5/vendor_perl/HTML/ElementSuper.pm -r--r--r-- 1 root root 25777 Jun 10 2010 /usr/share/perl5/vendor_perl/HTML/ElementTable.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-HTML-Element-Extended-1.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(HTML::Element) >= 3.01 1 perl(HTML::ElementGlob) 1 perl(HTML::ElementSuper) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(Tie::Array) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-HTML-Element-Extended-1.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl-HTML-Element-Extended = 1.18-1.fc19 1 perl(HTML::ElementGlob) = 1.18 1 perl(HTML::ElementRaw) = 1.18 1 perl(HTML::ElementSuper) = 1.18 1 perl(HTML::ElementSuper::ContentWatchdog) 1 perl(HTML::ElementTable) = 1.18 1 perl(HTML::ElementTable::DataElement) 1 perl(HTML::ElementTable::Element) 1 perl(HTML::ElementTable::HeaderElement) 1 perl(HTML::ElementTable::RowElement) 1 perl(HTML::ElementTable::RowGlob) Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-HTML-Element-Extended-1.18-1.fc19.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5090341). Ok.
Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Petr Šabata psabata@redhat.com --- New Package SCM Request ======================= Package Name: perl-HTML-Element-Extended Short Description: Various HTML::Element extensions Owners: psabata jplesnik ppisar Branches: f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
--- Comment #4 from Petr Šabata psabata@redhat.com --- Thank you both.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-HTML-Element-Extended-1.18-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-HTML-Element-Extended-1.18-1.fc...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918612
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-HTML-Element-Extended-1.18-1.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=918612
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-HTML-Element-Extended- | |1.18-1.fc18 Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-03 09:40:22
package-review@lists.fedoraproject.org