[Bug 668591] New: Review Request: - python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request:  - python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Summary: Review Request:  - python26-markupsafe - Implements a
                    XML/HTML/XHTML Markup safe string for Python
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://cern.ch/straylen/rpms/python26-markupsafe/python26-markupsafe.spec
SRPM URL:
http://cern.ch/straylen/rpms/python26-markupsafe/python26-markupsafe-0.11-2....
Description:
A library for safe markup escaping.

This is an EPEL5 only package for python26.

[Bug 668591] Review Request: - python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |662739

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:  -          |Review Request:
                   |python26-markupsafe -       |python26-markupsafe -
                   |Implements a XML/HTML/XHTML |Implements a XML/HTML/XHTML
                   |Markup safe string for      |Markup safe string for
                   |Python                      |Python

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Jeffrey Ness  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jeffrey Ness  2011-01-11 13:23:33 EST ---
Hello Steve,

This is unofficial as I am not yet sponsored, however below are a few things I
noticed.

While attempting to build this package with mock using epel-5-i386 I received
some issues:

running install_scripts
+ rm -rf
'/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/*.c'
+ chmod 755
/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so
chmod: cannot access
`/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so':
No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.12050 (%install)

running install_scripts
+ chmod 755
/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so
chmod: cannot access
`/var/tmp/python26-markupsafe-0.11-2.el5-root-mockbuild//usr/lib64/python2.6/site-packages/markupsafe/_speedups.so':
No such file or directory
--

The problems seems to be due to explicitly setting python26_sitearch to lib64:

%global python26_sitearch /usr/lib64/python2.6/site-packages

I would suggest being a bit less strict (or specifying the buildarch), below is
the macro I normally use for python_sitearch
(http://fedoraproject.org/wiki/Packaging:Python#Macros):

%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

--

Another thing I noticed is in your %files you own everything in the path by
this package:

%{python26_sitearch}/*

Please be more specific here as you do not wish to list files owned by other
packages in yours:

%{python26_sitearch}/markupsafe/
%{python26_sitearch}/MarkupSafe-0.11-py2.6.egg-info/

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #2 from Steve Traylen  2011-01-11 15:52:05 EST ---
Hi Jeffrey,

http://cern.ch/straylen/rpms/python26-markupsafe/python26-markupsafe.spec
http://cern.ch/straylen/rpms/python26-markupsafe/python26-markupsafe-0.11-3....

your comments are both certainly valid, thank you.

I've left the hardcoded 2.6 in the sitearch variable since the whole package
is very hardcoded to 2.6 and RHEL5 anyway. Of course I now use %{_libdir} for
the 32bit vs 64bit.

In fact if use

%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

in this case you get an error in koji since %{_pyhton} (python2.6) does
not exist when the .srpm is created.

Steve.

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|662739                      |662743

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #3 from Jeffrey Ness  2011-01-25 14:51:53 EST ---
Hello Steve,

I took your SRPM and was able to successfully build in mock using the
epel-5-i386 configuration (this config does have Python 2.6).

Below is a more detailed review:

Good:
* rpmlint cean
* Package follows naming guidelines
* Spec file name matches package name
* License is BSD in source and spec file
* BSD is an open source license
* License is included in the package doc
* Source matches upstream: md5sum 48d445941c16d6aa55caf8e148fc0911
* Builds in mock
* All build deps statisfied
* No locale files that need to be marked with %find_lang
* No shared libraries
* No bundled libraries
* Package is not relocatable
* No files listed more than once
* All files and directories created by the package owned by the package and no
others.
* Package contains code, not content.
* No large documentation that needs to be in a separate subpackage
* Nothing in %doc used at runtime
* No GUI application included so no .desktop requirement
* All filenames are valid utf-8
* No scriptlets
* No file dependencies
* No programs so no need for man pages
* Runs %checks with Python test suite

Again this is a non official review, but it should help get the ball rolling.

Jeffrey-

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #4 from Steve Traylen  2011-01-25 15:16:30 EST ---
Hi Jeffery,
Thanks for the unofficial review, I was guessing that you wish to become
a packager but could not see any of your submissions?
Steve.

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #5 from Jeffrey Ness  2011-01-25 15:58:11 EST ---
Hey Steve,

You are very welcome, and you are correct I am trying to get sponsored.

Toshio has been helping me in Package
https://bugzilla.redhat.com/show_bug.cgi?id=667155, and I believe I am rather
close :)

Jeffrey-

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Jeffrey Ness  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #6 from Jeffrey Ness  2011-01-26 15:19:12 EST ---
All mentioned problems taken care of.  This package is APPROVED.

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-cvs?

--- Comment #7 from Steve Traylen  2011-01-26 16:28:28 EST ---
New Package SCM Request
=======================
Package Name: python26-markupsafe
Short Description: Implements a XML/HTML/XHTML Markup safe string for Python
Owners: stevetraylen
Branches: el5
InitialCC:

This is an EPEL5 only package.

Jeffrey,
When you take a package for review
you should click the "take" next to the "assigned" above and set the status
to assigned.

Thanks for the review and welcome.

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #8 from Jason Tibbitts  2011-01-26 16:36:30 EST ---
Git done (by process-git-requests).

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #9 from Fedora Update System  2011-01-26 16:54:17 EST ---
python26-markupsafe-0.11-3.el5 has been submitted as an update for Fedora EPEL
5.
https://admin.fedoraproject.org/updates/python26-markupsafe-0.11-3.el5

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System  2011-01-27 13:23:37 EST ---
python26-markupsafe-0.11-3.el5 has been pushed to the Fedora EPEL 5 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python26-markupsafe'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/python26-markupsafe-0.11-3.el5

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |675628

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

--- Comment #11 from Fedora Update System  2011-02-12 19:22:19 EST ---
python26-markupsafe-0.11-3.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 668591] Review Request: python26-markupsafe - Implements a XML/HTML/XHTML Markup safe string for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=668591

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |python26-markupsafe-0.11-3.
                   |                            |el5
         Resolution|                            |ERRATA
        Last Closed|                            |2011-02-12 19:22:24