[Bug 474746] New: Review Request: supybot-koji - Plugin for Supybot to interact with Koji instances
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: supybot-koji - Plugin for Supybot to interact with Koji instances
https://bugzilla.redhat.com/show_bug.cgi?id=474746
Summary: Review Request: supybot-koji - Plugin for Supybot to interact with Koji instances Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonstanley@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
SRPM URL: http://jstanley.fedorapeople.org/supybot-koji-0.1-1.fc9.src.rpm Spec URL: http://jstanley.fedorapeople.org/supybot-koji.spec Description:
A Supybot plugin which provides access to the status of a Koji buildsystem and makes it available via IRC.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Flag| |fedora-review?
--- Comment #1 from manuel wolfshant wolfy@nobugconsulting.ro 2008-12-05 06:42:56 EDT --- Source0 should be https://fedorahosted.org/releases/s/u/%name/%%7Bname%7D-%%7Bversion%7D.tar.b...
%install lacks rm -rf $RPM_BUILD_ROOT
Everyhing else seems fine, please fix the above and we are good to go.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #2 from Jon Stanley jonstanley@gmail.com 2008-12-05 21:06:01 EDT --- Oh, never mind about the %install in the other bug, I was thinking about the wrong end of %install :) More caffeine required.
All fixed, new one for this is at http://jstanley.fedorapeople.org/supybot-koji-0.1-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from manuel wolfshant wolfy@nobugconsulting.ro 2008-12-06 06:06:33 EDT --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!] License field in the package spec file matches the actual license. License type as specidied by spec:BSD with advertising License type from source: New BSD (no advertising, 3 clause) ==> http://fedoraproject.org/wiki/Licensing/BSD#3ClauseBSD seems closer to the license in the source file [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package do not match the upstream source, as provided in the spec URL. SHA1SUM : 1914235584a8f004b283a0ffbaab7923b04fc2a0 supybot-koji-0.1.tar.bz2 [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on:package is noarch, should work on any arch with a proper python [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane.
=== Note === As for supybot-fedora, please recheck the license. I think that http://fedoraproject.org/wiki/Licensing/BSD#3ClauseBSD is the correct one to be used in the spec and not http://fedoraproject.org/wiki/Licensing/BSD#BSDwithAdvertising
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
Jon Stanley jonstanley@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Jon Stanley jonstanley@gmail.com 2008-12-07 16:55:35 EDT --- New Package CVS Request ======================= Package Name: supybot-koji Short Description: Supybot plugin to intercat with Koji instances Owners: jstanley Branches: EL-5 F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2008-12-07 19:38:58 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2008-12-07 20:53:39 EDT --- supybot-fedora-0.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/supybot-fedora-0.2-4.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2008-12-07 21:17:03 EDT --- supybot-koji-0.1-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/supybot-koji-0.1-3.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2008-12-07 21:18:38 EDT --- supybot-koji-0.1-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/supybot-koji-0.1-3.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2008-12-09 06:31:50 EDT --- supybot-koji-0.1-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-12-09 06:38:02 EDT --- supybot-fedora-0.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=474746
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-12-09 06:38:50 EDT --- supybot-koji-0.1-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla