[Bug 1664926] New: Review Request: python-lesspass - LessPass CLI open source password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Bug ID: 1664926 Summary: Review Request: python-lesspass - LessPass CLI open source password manager Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: luis@blackfile.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blackfile.fedorapeople.org/lesspass/lesspass.spec SRPM URL: https://blackfile.fedorapeople.org/lesspass/python-lesspass-6.1.0-1.fc29.src... Description: LessPass - stateless password generatorUsage: lesspass SITE [LOGIN] [MASTER_PASSWORD] [OPTIONS]Arguments: SITE site used in the password generation (required) LOGIN login used in the password generation default to '' if not provided MASTER_PASSWORD master password used in password generation default to LESSPASS_MASTER_PASSWORD env variable or promptOptions. Fedora Account System Username:blackfile
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Luis Bazan bazanluis20@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |bazanluis20@gmail.com Assignee|nobody@fedoraproject.org |bazanluis20@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
--- Comment #1 from Luis Segundo luis@blackfile.net --- Spec URL: https://blackfile.fedorapeople.org/lesspass/python-lesspass.spec SRPM URL: https://blackfile.fedorapeople.org/lesspass/python-lesspass-6.1.0-1.fc29.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Luis Bazan bazanluis20@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
--- Comment #2 from Luis Bazan bazanluis20@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-lesspass-6.1.0-1.fc30.noarch.rpm python-lesspass-6.1.0-1.fc30.src.rpm python3-lesspass.noarch: W: spelling-error %description -l en_US generatorUsage -> generator Usage, generator-usage, generator python3-lesspass.noarch: W: spelling-error %description -l en_US env -> enc, en, envy python3-lesspass.noarch: W: spelling-error %description -l en_US promptOptions -> prompt Options, prompt-options, proscriptions python3-lesspass.noarch: W: invalid-license GPL-3.0 python3-lesspass.noarch: W: no-documentation python3-lesspass.noarch: W: no-manual-page-for-binary lesspass python-lesspass.src: W: spelling-error %description -l en_US generatorUsage -> generator Usage, generator-usage, generator python-lesspass.src: W: spelling-error %description -l en_US env -> enc, en, envy python-lesspass.src: W: spelling-error %description -l en_US promptOptions -> prompt Options, prompt-options, proscriptions python-lesspass.src: W: invalid-license GPL-3.0 2 packages and 0 specfiles checked; 0 errors, 10 warnings.
-> Please fix this and I can approve package
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Requires -------- python3-lesspass (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi)
Provides -------- python3-lesspass: python3-lesspass python3.7dist(lesspass) python3dist(lesspass)
Source checksums ---------------- https://files.pythonhosted.org/packages/source/l/lesspass/lesspass-6.1.0.tar... : CHECKSUM(SHA256) this package : 58d51f47bd3a533acdd313b663162ae5ce8bd63a8dbad8e5c5b446e8ab18214c CHECKSUM(SHA256) upstream package : 58d51f47bd3a533acdd313b663162ae5ce8bd63a8dbad8e5c5b446e8ab18214c
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1664926 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Luis Bazan bazanluis20@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bazanluis20@gmail.com |nobody@fedoraproject.org
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Luis Bazan bazanluis20@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW
https://bugzilla.redhat.com/show_bug.cgi?id=1664926
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Flags|fedora-review? |
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Luis Segundo luis@blackfile.net's needinfo: Bug 1664926: Review Request: python-lesspass - LessPass CLI open source password manager https://bugzilla.redhat.com/show_bug.cgi?id=1664926
--- Comment #4 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com