[Bug 2319247] New: Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Bug ID: 2319247
           Summary: Review Request: rust-isa-rs - Isa-l Rust bindings
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
        Depends On: 2319246
            Blocks: 2277635
  Target Milestone: ---
    Classification: Fedora

Created attachment 2052364
  --> https://bugzilla.redhat.com/attachment.cgi?id=2052364&action=edit
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-isal-rs.spec
SRPM URL: https://music.fedorapeople.org/rust-isal-rs-0.5.3-1.fc40.src.rpm
Description: Isa-l Rust bindings.
Fedora Account System Username: music

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2277635
[Bug 2277635] rust-libcramjam-0.6.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2319246
[Bug 2319246] Review Request: rust-isal-sys - Isa-l sys crate

[Bug 2319247] Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #1 from Fedora Review Service  ---
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2319247] Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #2 from Fedora Review Service  ---
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2319247] Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #3 from Ben Beasley  ---
COPR build with fedora-review enabled:
https://copr.fedorainfracloud.org/coprs/music/libcramjam/build/8143387/

[Bug 2319247] Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #4 from Ben Beasley  ---
I need to add this on import:

# https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
  # Additionally, the isa-l package is ExcludeArch: %%{ix86}.
  ExcludeArch:    %{ix86}

[Bug 2319247] Review Request: rust-isa-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247
Bug 2319247 depends on bug 2319246, which changed state.

Bug 2319246 Summary: Review Request: rust-isal-sys - Isa-l sys crate
https://bugzilla.redhat.com/show_bug.cgi?id=2319246

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: rust-isa-rs |Review Request:
                   |- Isa-l Rust bindings       |rust-isal-rs - Isa-l Rust
                   |                            |bindings

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #5 from Ben Beasley  ---
(In reply to Ben Beasley from comment #4)
> I need to add this on import:
>
> # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
>   # Additionally, the isa-l package is ExcludeArch: %%{ix86}.
>   ExcludeArch:    %{ix86}

I went ahead and added this and uploaded a new submission.

New Spec URL: https://music.fedorapeople.org/20241019/rust-isal-rs.spec
New SRPM URL:
https://music.fedorapeople.org/20241019/rust-isal-rs-0.5.3-1.fc40.src.rpm

Koji scratch build in Rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=124981600

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/is
                   |                            |al-rs

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8158117
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #7 from Ben Beasley  ---
(In reply to Fedora Review Service from comment #6)
> Please make sure the package builds successfully at least for Fedora Rawhide.

(The rust-isal-sys dependency is in the Rawhide buildroot, but apparently has
not yet been included in a compose.)

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #16 from Fedora Update System  ---
FEDORA-2024-6b4790a9f9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-6b4790a9f9 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b4790a9f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #17 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #18 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #19 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-a8a3e0780a`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #20 from Fedora Update System  ---
FEDORA-2024-6b4790a9f9 (rust-isal-rs-0.5.3-2.fc40 and
rust-isal-sys-0.5.3-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #21 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a (cramjam-cli-0.1.1-9.fc41, python-cramjam-2.9.1-1.fc41,
and 3 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #8 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

You might want to regenerate with rust2rpm v27 before importing.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #9 from Ben Beasley  ---
Thank you for the review! I’m looking forward to getting the cramjam packages
up to date.

https://release-monitoring.org/project/375028/

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #10 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-isal-rs

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #11 from Fedora Update System  ---
FEDORA-2024-51ef43d569 (rust-isal-rs-0.5.3-2.fc42) has been submitted as an
update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-51ef43d569

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-12-08 13:25:25

--- Comment #12 from Fedora Update System  ---
FEDORA-2024-51ef43d569 (rust-isal-rs-0.5.3-2.fc42) has been pushed to the
Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #13 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a (rust-isal-rs-0.5.3-2.fc41) has been submitted as an
update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #14 from Fedora Update System  ---
FEDORA-2024-6b4790a9f9 (rust-isal-rs-0.5.3-2.fc40 and
rust-isal-sys-0.5.3-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6b4790a9f9

[Bug 2319247] Review Request: rust-isal-rs - Isa-l Rust bindings

https://bugzilla.redhat.com/show_bug.cgi?id=2319247

--- Comment #15 from Fedora Update System  ---
FEDORA-2024-a8a3e0780a has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-a8a3e0780a *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a8a3e0780a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.