[Bug 446814] New: Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Summary: Review Request: emacs-lookup - Emacsen interface to look
                    up dictionaries
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup.spec
SRPM URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup-1.4.1-1.fc9.src.rpm
Description:

Lookup is an integrated search interface with electronic dictionaries
for Emacsen. You can use various kinds of dictionaries, such as CD-ROM books
and online dictionaries, in an efficient and effective manner.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-lookup - Emacsen interface to look up dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=446814

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-06-21 19:21 EST -------
This fails to build in mock for me; the build completes, but the final assembly
process fails with:

error: Installed (but unpackaged) file(s) found:
   /usr/share/info/dir

It's recommended that you rm -f this; whether it is generated or not depends on
several things, but it should never be included in the package.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-lookup - Emacsen interface to look up dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=446814

------- Additional Comments From [e-mail]  2008-06-22 23:28 EST -------
Thank you for catching this up. wasn't aware of that so that I didn't see that
error here. anyway fixed in:

Spec URL: http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup.spec
SRPM URL:
http://tagoh.fedorapeople.org/emacs-lookup/emacs-lookup-1.4.1-2.fc9.src.rpm

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-lookup - Emacsen interface to look up dictionaries

https://bugzilla.redhat.com/show_bug.cgi?id=446814

------- Additional Comments From [e-mail]  2008-06-25 00:26 EST -------
I had intended to get back to this with some more review commentary so we didn't
have to go back and forth, but I ran out of time, sorry.

I notice that the lookup-guide.info file isn't in UTF8, and isn't in any
encoding I recognize, so it doesn't render at all for me.  (rpmlint complains
it, of course.)  Do you know what the encoding is?  Is it possible to convert to
UTF8 so that everyone can at least look at the file without having to set some
specific encoding?

I get a "406 Not Acceptable" error when visiting the URL given in the spec.  I
expect that the server is trying to present a page based on my language
settings, but none exists.  Perhaps it would be better to simply refer directly
to the Japanese page at http://openlab.jp/edict/lookup/index.html.ja. 
Unfortunately my Japanese is only good enough to read a few words (and most of
the gairaigo) on that page, but it's obviously a reasonable page to use as the
URL for this package.

Unfortunately this package fails to conform to many of the Emacs packaging
guidelines given in http://fedoraproject.org/wiki/Packaging/Emacs.  The
versioned dependencies are missing, the build dependencies are not correct
(although the package still builds for me), there are no separate -el packages,
etc.  There are some pretty complete templates on the guideline page which you
can copy.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Tony Fu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]    |[e-mail]

--- Comment #4 from Tony Fu   2008-09-09 23:07:27 EDT ---
requested by Jens Petersen (#27995)

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail])

--- Comment #5 from Jason Tibbitts   2008-11-07 19:38:16 EDT ---
So its been over four months since I made my comments with no response.  I will
close this ticket soon if there is no further progress.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
             Blocks|                            |201449
         Resolution|                            |NOTABUG
               Flag|needinfo?([e-mail]) |

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Daiki Ueno  2010-04-06 03:12:11 EDT ---
I've just packaged Lookup 2.0 beta, which is a major rewrite of 1.4 and works
much more seamlessly with Emacs 23.  Here are spec and SRPM:

Spec URL:
http://www.unixuser.org/~ueno/software/fedora/lookup/emacs-lookup.spec
SRPM URL:
http://www.unixuser.org/~ueno/software/fedora/lookup/emacs-lookup-1.99.95-1....

Notes:
- Since the upstream no longer supports XEmacs (see NEWS), I packaged it for
GNU Emacs only.
- The spec file is based on the template on the Emacs packaging policy so it
should not contain issues mentioned above.
- I concluded the license is GPLv3+ since the package contains both GPLv2+ and
GPLv3+ files.

If it is ok, I'm available for maintaining the package.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

--- Comment #7 from Mamoru Tasaka  2010-04-06 03:25:50 EDT ---
(In reply to comment #6)
> If it is ok, I'm available for maintaining the package.

If you want to import this package into Fedora, please file
a new review request and mark this ticket as a duplicate of the
new one.

[Bug 446814] Review Request: emacs-lookup - Emacsen interface to look up dictionaries

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=446814

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |DUPLICATE

--- Comment #8 from Daiki Ueno  2010-04-06 03:40:43 EDT ---
Done, thanks.

*** This bug has been marked as a duplicate of bug 579662 ***