Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
Summary: Review Request: php-pecl-radius - Radius client library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: chris.stone@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius-1.2.4-1.src.rpm
Description: This package is based on the libradius of FreeBSD, with some modifications and extensions. This PECL provides full support for RADIUS authentication (RFC 2865) and RADIUS accounting (RFC 2866), works on Unix and on Windows. Its an easy way to authenticate your users against the user-database of your OS (for example against Windows Active-Directory via IAS).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-pecl-radius
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
matthias@rpmforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias@rpmforge.net
------- Additional Comments From matthias@rpmforge.net 2007-02-13 13:49 EST ------- I wanted to take a quick look at this package, but it seems that tkmame.retrogames.com is unavailable at the moment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From chris.stone@gmail.com 2007-02-13 15:45 EST ------- Unfortunately not the most reliable server. Seems to be back up now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |Fedora@FamilleCollet.com
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-10 10:45 EST ------- What about using the new provides to ensure ABI compatibility with PHP
For example %if %{?php_zend_api}0 # for fedora >= 6 Requires: php(zend-abi) = %{php_zend_api} Requires: php(api) = %{php_core_api} %else # for fedora <= 5 Requires: php-api = %{php_apiver} %endif
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-11 03:20 EST ------- As for php-pear packages, php-pecl tarball have a package.xml outside any directory. So, you must use
%prep %setup -c -q cd radius-%{version}
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |Fedora@FamilleCollet.com OtherBugsDependingO|163776 |163778 nThis| | Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-11 09:52 EST ------- I finally succeed to install a local radius server and to have a working test for this extension, so,
=== REVIEW === :) source files match upstream: 3d48ccb9486b9e8839d814d7ff318091 radius-1.2.4.tgz :) package meets naming and packaging guidelines. :( specfile is properly named, is cleanly written and uses macros consistently. => see comment #4 :) dist tag is present. :) build root is correct (second form). :) license field matches the actual license. :) license is open source-compatible (BSD). :) latest version is being packaged (1.2.4) :) BuildRequires are proper. :) %clean is present. :) package builds in mock (FC6). :) package installs properly :) rpmlint is silent. :) final provides are sane: config(php-pecl-radius) = 1.2.4-1.fc7 php-pecl(radius) = 1.2.4-1.fc7 radius.so()(64bit) php-pecl-radius = 1.2.4-1.fc7 :/ final Requires are sane: => see comment # 3 :) %check is not present; :) owns the directories it creates :) no duplicates in %files. :) file permissions are appropriate. :) no scriplet :) code, not content. :) documentation is small, so no -docs subpackage is necessary. :) %docs are not necessary for the proper functioning of the package.
Don't know if "release" is need in virtual provide 'php-pecl(radius)' ? perl and php-pear virtual provide never used it.
Should : comment #3 Must: comment #4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From chris.stone@gmail.com 2007-03-11 17:29 EST ------- Indeed, my php-pecl-xdebug package will also need to be fixed. Thanks for spotting this.
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius-1.2.4-2.src.rpm
%changelog * Sun Mar 11 2007 Christopher Stone chris.stone@gmail.com 1.2.4-2 - Use new ABI check for FC-6 - Create directory to untar sources - Remove %%{release} from Provides
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
Fedora@FamilleCollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag|fedora-review? |fedora-review+
------- Additional Comments From Fedora@FamilleCollet.com 2007-03-12 01:12 EST ------- Option -n to %setup is not needed... but not a issue.
== APPROVED ==
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From chris.stone@gmail.com 2007-03-12 14:46 EST ------- New Package CVS Request ======================= Package Name: php-pecl-radius Short Description: Radius client library Owners: chris.stone@gmail.com Branches: FC-5 FC6 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
------- Additional Comments From chris.stone@gmail.com 2007-03-13 04:04 EST ------- - Fixed -n option - Imported and built on FC-5 FC-6 and devel
Thanks for the review!
:D
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From chris.stone@gmail.com 2007-05-10 17:33 EST ------- Package Change Request ====================== Package Name: php-pecl-radius New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pecl-radius - Radius client library Alias: php-pecl-radius
https://bugzilla.redhat.com/show_bug.cgi?id=222598
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla