[Bug 2294109] New: Review Request: golang-github-nvidia-nvlib - A collection of useful Go libraries for use with NVIDIA GPU management tools
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Bug ID: 2294109 Summary: Review Request: golang-github-nvidia-nvlib - A collection of useful Go libraries for use with NVIDIA GPU management tools Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: debarshir@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38...
Description:
A collection of useful Go libraries for use with NVIDIA GPU management tools.
This package contains the source code needed for building packages that reference the following Go import paths: – github.com/NVIDIA/go-nvlib
Fedora Account System Username: rishi
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #2 from Debarshi Ray debarshir@redhat.com --- Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38...
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Debarshi Ray debarshir@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2293636
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2293636 [Bug 2293636] Review Request: golang-github-nvidia-nvml - Go Bindings for the NVIDIA Management Library (NVML)
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #3 from Debarshi Ray debarshir@redhat.com --- The latest release of the github.com/NVIDIA/go-nvlib module is v0.6.0. However, anything more recent than v0.2.0 is not compatible with the latest v1.15.0 release of github.com/NVIDIA/nvidia-container-toolkit. That's why I chose to package only v0.2.0 for the time being. We can update once there's a newer release of the github.com/NVIDIA/nvidia-container-toolkit module.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #4 from Debarshi Ray debarshir@redhat.com --- (In reply to Debarshi Ray from comment #2)
Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38. noarch.rpm
Damn, that's not the SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #5 from Debarshi Ray debarshir@redhat.com --- Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-0.2.0-1.fc38.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7663311 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #7 from Debarshi Ray debarshir@redhat.com --- (In reply to Fedora Review Service from comment #6)
Copr build: https://copr.fedorainfracloud.org/coprs/build/7663311 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- review-2294109-golang-github-nvidia-nvlib/fedora-rawhide-x86_64/07663311- golang-github-nvidia-nvlib/builder-live.log.gz
Please make sure the package builds successfully at least for Fedora Rawhide.
The build failed with: No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/dl) No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/nvml)
That's going to be addressed by the package review of golang-github-nvidia-nvml in bug 2293636
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #8 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
install --mode 0644 --preserve-timestamps --verbose \ pkg/pciids/default_pci.ids \ %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/ (...) %{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
You can replace this with after `%global godoc`:
%global gosupfiles pkg/pciids/default_pci.ids
Check golang-github-projectdiscovery-cdncheck.spec or golang-x-crypto.spec as example.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109 Bug 2294109 depends on bug 2293636, which changed state.
Bug 2293636 Summary: Review Request: golang-github-nvidia-nvml - Go Bindings for the NVIDIA Management Library (NVML) https://bugzilla.redhat.com/show_bug.cgi?id=2293636
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #9 from Debarshi Ray debarshir@redhat.com --- (In reply to Mikel Olasagasti Uranga from comment #8)
install --mode 0644 --preserve-timestamps --verbose \ pkg/pciids/default_pci.ids \ %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/ (...) %{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
You can replace this with after `%global godoc`:
%global gosupfiles pkg/pciids/default_pci.ids
Check golang-github-projectdiscovery-cdncheck.spec or golang-x-crypto.spec as example.
I haven't forgotten about this. I got swamped wrapping up work before leaving on vacation. So, I will pick this up once I am back on the 28th of July.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #10 from Debarshi Ray debarshir@redhat.com --- Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-0.6.1-1.fc40.src.r...
I updated it to the latest version of the NVIDIA stack, where everything builds together.
(In reply to Mikel Olasagasti Uranga from comment #8)
install --mode 0644 --preserve-timestamps --verbose \ pkg/pciids/default_pci.ids \ %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/ (...) %{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
You can replace this with after `%global godoc`:
%global gosupfiles pkg/pciids/default_pci.ids
Done.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #11 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #12 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-nvidia-nvlib
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #13 from Debarshi Ray debarshir@redhat.com --- Requested Git repository: https://pagure.io/releng/fedora-scm-requests/issue/67756
Requested Git branches for f41, f40 and f39: https://pagure.io/releng/fedora-scm-requests/issue/67759 https://pagure.io/releng/fedora-scm-requests/issue/67757 https://pagure.io/releng/fedora-scm-requests/issue/67758
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #14 from Debarshi Ray debarshir@redhat.com --- (In reply to Mikel Olasagasti Uranga from comment #11)
[...]
Package approved! On import, don't forget to do the following:
Thanks, Mikel.
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and
the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Okay, I will do those.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #15 from Debarshi Ray debarshir@redhat.com --- Added https://github.com/NVIDIA/go-nvlib to Anitya: https://release-monitoring.org/project/374561/
... and enabled monitoring in Fedora: https://src.fedoraproject.org/rpms/golang-github-nvidia-nvlib
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2f7d355591 (golang-github-nvidia-nvlib-0.6.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f7d355591
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-dd8ef6d9f2 (golang-github-nvidia-nvlib-0.6.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-dd8ef6d9f2
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9eaea5bc2e (golang-github-nvidia-nvlib-0.6.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eaea5bc2e
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9eaea5bc2e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9eaea5bc2e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eaea5bc2e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-dd8ef6d9f2 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-dd8ef6d9f2 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-dd8ef6d9f2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2f7d355591 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2f7d355591 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f7d355591
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2024-10-02 01:31:51
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2f7d355591 (golang-github-nvidia-nvlib-0.6.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-dd8ef6d9f2 (golang-github-nvidia-nvlib-0.6.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2294109
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-9eaea5bc2e (golang-github-nvidia-nvlib-0.6.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com