[Bug 1232816] New: Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Bug ID: 1232816
           Summary: Review Request: nodejs-spdx - SPDX License Expression
                    Syntax parser
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-1.fc2...
Description: SPDX License Expression Syntax parser
Fedora Account System Username: zvetlik

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Zuzana Svetlikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1232777

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1232777
[Bug 1232777] Review Request: nodejs-spdx-license-ids - A list of SPDX
license identifiers

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Zuzana Svetlikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |956806 (nodejs-reviews)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Piotr Popieluch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
         QA Contact|[e-mail] |
              Flags|                            |fedora-review-

--- Comment #1 from Piotr Popieluch  ---
License should be:

"ASL 2.0"

see
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_...
for correct license Short Names

Source0 incorrect

https://github.com/kemitchell/%%7Bgithub_name%7D/archive/%%7Bgithub_name%7D-...

should be

https://github.com/kemitchell/%%7Bgithub_name%7D/archive/%%7Bcommit%7D/%%7Bg...

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816
Bug 1232816 depends on bug 1232777, which changed state.

Bug 1232777 Summary: Review Request: nodejs-spdx-license-ids - A list of SPDX license identifiers
https://bugzilla.redhat.com/show_bug.cgi?id=1232777

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Zuzana Svetlikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1248428

--- Comment #2 from Zuzana Svetlikova  ---
New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-2.fc2...

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1248428
[Bug 1248428] Rebase to npm 2.x

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #3 from Piotr Popieluch  ---
Hi Zuzana,

It seems that this module needs to be built, see package.json:
  "scripts": {
    "build": "node build/parser.js > source/parser.generated.js",

The generated file is needed for proper functioning, see spdx.js:
source/spdx.js:var parser = require('./parser.generated.js').parser;

Building depends on npm(jison) which is not in Fedora yet.

Small other comment:
If you are targetting el6 than you have to change the ExclusiveArch:

%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif

If you are not buildinf for el6 then you can remove the 
%{?nodejs_find_provides_and_requires}
macro.

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #4 from Zuzana Svetlikova  ---
New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc2...

Sources from npmjs don't contain build scripts, so it probably works without
it.

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #5 from Zuzana Svetlikova  ---
Sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc2...

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Piotr Popieluch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from Piotr Popieluch  ---
I think you will have to generate the code from source, which will involve
packaging jison.

https://lists.fedoraproject.org/archives/list/nodejs%40lists.fedoraproject.o...

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #7 from Piotr Popieluch  ---
Some issues:

There is a missing dependency: spdx-exceptions

Version is missing in changelog

Check section incorrect, should be: defence README.md | replace-require-self |
node

New versions license is MIT, not Apache

You can leave out the "Requires: npm(spdx-license-ids)" this is handled
automatically

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #8 from Piotr Popieluch  ---
Any updates?

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Piotr Popieluch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(zsvetlik@redhat.c
                   |                            |om)

--- Comment #9 from Piotr Popieluch  ---
Are you still interested in packaging this module?

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Zuzana Svetlikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(zsvetlik@redhat.c |
                   |om)                         |

--- Comment #10 from Zuzana Svetlikova  ---
Sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL:
https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.5.1-1.f26...

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

--- Comment #11 from Piotr Popieluch  ---
The parser.generated.js file needs to be built this should be done in the
%build section with:
node generate-parser.js > parser.generated.js

After it is built, it must be copied in the install section.

It does not have to be built in the %check section.

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Piotr Popieluch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |
           Assignee|[e-mail]         |[e-mail]
              Flags|fedora-review-              |