[Bug 2120450] New: Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Bug ID: 2120450
           Summary: Review Request: golang-github-twpayne-vfs-3 - v3
                    import path of twpayne-vfs
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/...
Description: Package vfs provides an abstraction of the os and io packages that
is easy to test.
Fedora Account System Username: anthr76/@GoSig

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

--- Comment #1 from Anthony Rabbito  ---
Updated spec to use `gometa -f`

Spec URL:
https://anthr76.fedorapeople.org/golang-github-twpayne-vfs-3/golang-github-t...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-twpayne-vfs-3/golang-github-t...

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2130734

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2130734
[Bug 2130734] Review Request: Chezmoi - Manage your dotfiles across multiple
diverse machines, securely.

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2130734                     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2130734
[Bug 2130734] Review Request: Chezmoi - Manage your dotfiles across multiple
diverse machines, securely.

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2120454

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2120454
[Bug 2120454] Review Request: golang-github-twpayne-xdg-6 - v6 import path of
twpayne/xdg

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]

--- Comment #2 from Mikel Olasagasti Uranga  ---
Spec is correct, but I've one doubt.

Diff between v3 and v4 has not any relevant change over previous version:

https://github.com/twpayne/go-vfs/compare/v3.0.0...v4.1.0

I've checked if xdg-v6 package could work with go-vfs-v4 and, as expected,
works fine.

https://github.com/twpayne/go-xdg/pull/7

I see three options:

a) Package go-vfs-v3 as-is in this BZ
b) Package go-vfs-v4 and patch xdg-v6 to switch (sed or patch) from go-vfs-v3
to go-vfs-v4
c) Package go-vfs non versioned, and modify xdg-v6 spec to replace dependency
of go-vfs

I would go with option b, so in case any other package depends on it can use
the latest version, but as you prefer.

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
        Environment|                            |If this bug requires
                   |                            |documentation, please
                   |                            |select an appropriate Doc
                   |                            |Type value.

--- Comment #3 from Mikel Olasagasti Uranga  ---
Now I see that chezmoi itself depends on go-vfs-v4 and that a review is pending
for it: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2120452

Based on this, please, go with option b, close this BZ and we go with
BZ2120452.

[Bug 2120450] Review Request: golang-github-twpayne-vfs-3 - v3 import path of twpayne-vfs

https://bugzilla.redhat.com/show_bug.cgi?id=2120450

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2022-10-05 23:18:07

--- Comment #4 from Anthony Rabbito  ---
Sure Mikel. We will go with option B

Thank you very much for the upstream patch. Cheers!