https://bugzilla.redhat.com/show_bug.cgi?id=2283593
Bug ID: 2283593 Summary: Review Request: rust-futures-time - Async time combinators Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-futures-time/rust-futures-time... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-futures-time/rust-futures-time...
Description: Async time combinators.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118191844
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2283598
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283598 [Bug 2283598] Review Request: rust-redis - Driver for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Status|NEW |POST Assignee|nobody@fedoraproject.org |jonathan@almalinux.org CC| |jonathan@almalinux.org
--- Comment #2 from Jonathan Wright jonathan@almalinux.org --- The review below cites invalid line-endings in /usr/share/cargo/registry/futures-time-3.0.0/README.md. It's not a blocker for me but it'd be nice if upstream could fix that.
/usr/share/cargo/registry/futures-time-3.0.0/tests/test.rs ends up an empty file. If it's going to stay that way it'd be nice to remove it.
Package APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/futures- time-3.0.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 34 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora-review/2283593-rust-futures- time/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- futures-time-devel , rust-futures-time+default-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: rust-futures-time-devel-3.0.0-1.fc41.noarch.rpm rust-futures-time+default-devel-3.0.0-1.fc41.noarch.rpm rust-futures-time-3.0.0-1.fc41.src.rpm ============================================================================================= rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpk1byat6i')] checks: 32, packages: 3
rust-futures-time-devel.noarch: E: zero-length /usr/share/cargo/registry/futures-time-3.0.0/tests/test.rs rust-futures-time-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/futures-time-3.0.0/README.md rust-futures-time+default-devel.noarch: E: spelling-error ('Async', 'Summary(en_US) Async -> Sync, A sync') rust-futures-time+default-devel.noarch: E: spelling-error ('combinators', 'Summary(en_US) combinators -> combinations, combination, contaminators') rust-futures-time+default-devel.noarch: E: spelling-error ('Async', '%description -l en_US Async -> Sync, A sync') rust-futures-time+default-devel.noarch: E: spelling-error ('combinators', '%description -l en_US combinators -> combinations, combination, contaminators') rust-futures-time.src: E: spelling-error ('Async', 'Summary(en_US) Async -> Sync, A sync') rust-futures-time.src: E: spelling-error ('combinators', 'Summary(en_US) combinators -> combinations, combination, contaminators') rust-futures-time.src: E: spelling-error ('Async', '%description -l en_US Async -> Sync, A sync') rust-futures-time.src: E: spelling-error ('combinators', '%description -l en_US combinators -> combinations, combination, contaminators') rust-futures-time-devel.noarch: E: spelling-error ('Async', 'Summary(en_US) Async -> Sync, A sync') rust-futures-time-devel.noarch: E: spelling-error ('combinators', 'Summary(en_US) combinators -> combinations, combination, contaminators') rust-futures-time-devel.noarch: E: spelling-error ('Async', '%description -l en_US Async -> Sync, A sync') rust-futures-time-devel.noarch: E: spelling-error ('combinators', '%description -l en_US combinators -> combinations, combination, contaminators') rust-futures-time+default-devel.noarch: W: no-documentation ====================================================== 3 packages and 0 specfiles checked; 13 errors, 2 warnings, 12 filtered, 13 badness; has taken 0.2 s ======================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
rust-futures-time-devel.noarch: E: zero-length /usr/share/cargo/registry/futures-time-3.0.0/tests/test.rs rust-futures-time-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/futures-time-3.0.0/README.md rust-futures-time+default-devel.noarch: E: spelling-error ('Async', 'Summary(en_US) Async -> Sync, A sync') rust-futures-time+default-devel.noarch: E: spelling-error ('combinators', 'Summary(en_US) combinators -> combinations, combination, contaminators') rust-futures-time+default-devel.noarch: E: spelling-error ('Async', '%description -l en_US Async -> Sync, A sync') rust-futures-time+default-devel.noarch: E: spelling-error ('combinators', '%description -l en_US combinators -> combinations, combination, contaminators') rust-futures-time-devel.noarch: E: spelling-error ('Async', 'Summary(en_US) Async -> Sync, A sync') rust-futures-time-devel.noarch: E: spelling-error ('combinators', 'Summary(en_US) combinators -> combinations, combination, contaminators') rust-futures-time-devel.noarch: E: spelling-error ('Async', '%description -l en_US Async -> Sync, A sync') rust-futures-time-devel.noarch: E: spelling-error ('combinators', '%description -l en_US combinators -> combinations, combination, contaminators') rust-futures-time+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 9 errors, 2 warnings, 8 filtered, 9 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/futures-time/3.0.0/download#/futures-time-3.... : CHECKSUM(SHA256) this package : 6404853a6824881fe5f7d662d147dc4e84ecd2259ba0378f272a71dab600758a CHECKSUM(SHA256) upstream package : 6404853a6824881fe5f7d662d147dc4e84ecd2259ba0378f272a71dab600758a
Requires -------- rust-futures-time-devel (rpmlib, GLIBC filtered): (crate(async-channel/default) >= 1.6.1 with crate(async-channel/default) < 2.0.0~) (crate(async-io/default) >= 1.6.0 with crate(async-io/default) < 2.0.0~) (crate(futures-core/default) >= 0.3.19 with crate(futures-core/default) < 0.4.0~) (crate(pin-project-lite/default) >= 0.2.8 with crate(pin-project-lite/default) < 0.3.0~) cargo
rust-futures-time+default-devel (rpmlib, GLIBC filtered): cargo crate(futures-time)
Provides -------- rust-futures-time-devel: crate(futures-time) rust-futures-time-devel
rust-futures-time+default-devel: crate(futures-time/default) rust-futures-time+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2283593 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Python, Ocaml, Haskell, C/C++, fonts, Java, SugarActivity, PHP, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-futures-time
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-dc72d48a9c (rust-futures-time-3.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-dc72d48a9c
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-06-22 08:44:27
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-dc72d48a9c (rust-futures-time-3.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-faf2eb870f (rust-futures-time-3.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-faf2eb870f
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-faf2eb870f has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-faf2eb870f *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-faf2eb870f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2283593
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-faf2eb870f (rust-futures-time-3.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org