[Bug 626004] New: Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Summary: Review Request: osm2pgsql - Imports map data from
                    OpenStreetMap to a PostgresSQL database
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql-0-0.1.20100821svn.fc13....

Project URL: http://wiki.openstreetmap.org/wiki/Osm2pgsql

Description:
Processes the planet file from the community mapping project at
http://www.openstreetmap.org. The map data is converted from XML to a
database stored in PostgreSQL with PostGIS geospatial extensions. This
database may then be used to render maps with Mapnik or for other
geospatial analysis.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2416108

rpmlint output:
[fab@laptop011 SRPMS]$ rpmlint osm2pgsql-0-0.1.20100821svn.fc13.src.rpm 
osm2pgsql.src: W: spelling-error %description -l en_US geospatial ->
hyperspatial, geostatic, spatial
osm2pgsql.src: W: invalid-url Source0: osm2pgsql-20100821svn.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[fab@laptop011 x86_64]$ rpmlint osm2pgsql*
osm2pgsql.x86_64: W: spelling-error %description -l en_US geospatial ->
hyperspatial, geostatic, spatial
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Ralph Lange  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ralph Lange  2010-09-03 14:39:07 EDT ---
I was having a look at your package, here's the short list of issues that I
see:

- The sources show (configure.ac) osm2pgsql claims to be at Version 0.69 - this
is also reported by the program itself. There's also a .spec.in file (from
2008) in the sources that uses Version 0.69 and Release 1.%{svn_ver}. So maybe
consider changing your package version numbers to Version: 0.69 and Release:
1.1.%{svn_ver}svn%{?dist} to keep version numbers monotone.

- The mock build shows two warnings that might be worthwhile fixing and/or
reporting to upstream:
  configure: WARNING: unrecognized options: --disable-dependency-tracking
and:
  osm2pgsql.c: In function 'main':
  osm2pgsql.c:818:28: warning: assignment from incompatible pointer type

- The program is supposed to report its version as %{version}-%{svn_ver}, but
the latter string is empty - that might also be worth fixing and sending
upstream.

- As the license is not included as text, the Guidelines suggest pointing this
out to upstream and asking them to correct this mistake.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Martin Gieseking  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Martin Gieseking  2010-09-04 07:42:05 EDT ---
(In reply to comment #1)
> The sources show (configure.ac) osm2pgsql claims to be at Version 0.69 - this
>
> is also reported by the program itself.

Good catch. I agree that the Version field should reflect the complete version
of the utility.
> Release: 1.1.%{svn_ver}svn%{?dist} to keep version numbers monotone.

Since there's no officially released source tarball on the upstream website,
this package is considered a "snapshot release". Such packages must follow the
numbering scheme described at
http://fedoraproject.org/wiki/PackageNamingGuidelines#PreReleasePackages

Thus, the current Release tag is OK.
> configure: WARNING: unrecognized options: --disable-dependency-tracking
> and:
>   osm2pgsql.c: In function 'main':
>   osm2pgsql.c:818:28: warning: assignment from incompatible pointer type

These seem to be minor issues that don't affect the functionality of the
program. However, they should of course be investigated by the upstream
developer.

Here are some more comments on the spec file:

- replace %define with %global (see
https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define)

- you can drop the --prefix option from %configure (--prefix=%{_prefix} is
  already part of the %configure macro)

- I recommend to be more specific in %files as there's only a single manpage
  to add: %{_mandir}/man1/osm2pgsql.1*

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Jon Burgess  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jon Burgess  2010-10-02 10:04:48 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > configure: WARNING: unrecognized options: --disable-dependency-tracking
> > and:
> >   osm2pgsql.c: In function 'main':
> >   osm2pgsql.c:818:28: warning: assignment from incompatible pointer type
>
> These seem to be minor issues that don't affect the functionality of the
> program. However, they should of course be investigated by the upstream
> developer.

Hi. I'm the main upstream author for osm2pgsql. I just committed a fix for that
warning in r23440 of the osm2pgsql SVN code.
> The program is supposed to report its version as %{version}-%{svn_ver}, but
>
> the latter string is empty - that might also be worth fixing and sending
> upstream.

In the upstream version the Makefile generates this via $(shell svnversion) but
the SVN metadata is discarded in the 'svn export' step. How about putting this
in the osm2pgsql.spec:

make %{?_smp_mflags} SVN=%{svn_ver}

This ends up being reported like:
$ /usr/bin/osm2pgsql -v
osm2pgsql SVN version 0.69-20101002

Alternative you could put %{release} in there. The purpose of this string is to
help myself and other developers keep track of which revision/snapshot someone
has used, anything which can be tracked back to a specific source version is
sufficient.
> As the license is not included as text, the Guidelines suggest pointing
>
> this out to upstream and asking them to correct this mistake.

What do you want here, a copy of the GPL COPYING file added into the osm2pgsql
SVN tree? I can do that if you want.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgresSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #4 from Martin Gieseking  2010-10-03 14:34:04 EDT ---
(In reply to comment #3)
> the SVN metadata is discarded in the 'svn export' step. How about putting this
> in the osm2pgsql.spec:
>
> make %{?_smp_mflags} SVN=%{svn_ver}

This addition shouldn't be a problem.
> What do you want here, a copy of the GPL COPYING file added into the osm2pgsql
> SVN tree?

Yes, please add file COPYING containing the GPLv2 license text to the SVN repo,
and also include it in future source tarballs of officially released versions. 
Your source file headers also refer to it: "You should have received a copy of
the GNU General Public License along with this program".

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Devrim GÜNDÜZ  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Review Request: osm2pgsql - |Review Request: osm2pgsql -
                   |Imports map data from       |Imports map data from
                   |OpenStreetMap to a          |OpenStreetMap to a
                   |PostgresSQL database        |PostgreSQL database

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #5 from Devrim GÜNDÜZ  2010-10-03 19:55:58 EDT ---
It is not PostgresSQL -- It is PostgreSQL. Could you please fix it in spec,
too?

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

viji  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from viji  2010-11-17 05:15:28 EST ---
Any update on this?

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |StalledSubmitter

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #7 from Fabian Affolter  2011-01-05 04:10:48 EST ---
Sorry, no update at the moment because I'm busy with other things.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|StalledSubmitter            |

--- Comment #8 from Fabian Affolter  2011-03-27 08:53:27 EDT ---
* Sun Mar 27 2011 Fabian Affolter  -
0.70.5-0.3.20110327svn
- Build with svn checkout detail as version information
- Remove gazetteer stuff, Patch for configure.ac and Makefile.am 
- Updated to new checkout

* Tue Nov 23 2010 Fabian Affolter  -
0-0.2.20101124svn
- Typo fixed in summary
- Prefix removed 
- Doc updated
- Replaced define

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql-0.70.5-0.3.20110327svn....

rpmlint output:
[fab@laptop023 SRPMS]$ rpmlint osm2pgsql-0.70.5-0.3.20110327svn.fc14.src.rpm 
osm2pgsql.src: W: spelling-error %description -l en_US geospatial ->
hyperspatial, geostatic, spatial
osm2pgsql.src: W: invalid-url Source0: osm2pgsql-20110327svn.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[fab@laptop023 x86_64]$ rpmlint osm2pgsql*
osm2pgsql.x86_64: W: spelling-error %description -l en_US geospatial ->
hyperspatial, geostatic, spatial
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Mario Blättermann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Mario Blättermann  2011-05-08 10:04:20 EDT ---
Koji scratch build was not successful for F15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058186
> From build.log:

autoreconf: running: aclocal -I m4 --output=aclocal.m4t
Can't exec "aclocal": Permission denied at
/usr/share/autoconf/Autom4te/FileUtils.pm line 326.
autoreconf: failed to run aclocal: Permission denied
error: Bad exit status from /var/tmp/rpm-tmp.xZSPvl (%build)

Same problem in F16:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058191

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #10 from Fabian Affolter  2011-06-25 06:57:22 EDT ---
Thanks Mario for your comment.

* Sat Jun 25 2011 Fabian Affolter  -
0.70.5-0.4.20110327svn
- Fix autotool issue (osm2pgsql-configure.patch updated)

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql-0.70.5-0.4.20110327svn....

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #11 from Roy Rankin  2011-06-27 07:14:24 EDT ---
Created attachment 510073
  --> https://bugzilla.redhat.com/attachment.cgi?id=510073
modified patch so osm2pgsql finds default.style

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Roy Rankin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #12 from Roy Rankin  2011-06-27 07:15:23 EDT ---
Fabian,

Under F15 mock still fails to build for me. Try
   1> backout the latest patch
   2> add BuildRequires:  automake

Also if you add "BuildRequires:  protobuf-c-devel" the program will be able to
process .pbf files.

Finally there is an upstream OSM Ticket #3457 "default.style location" which
should be fixed with the attached modified osm2pgsql-makefile.patch file.

These changes should allow me to start the review process.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #13 from Roy Rankin  2011-07-01 19:23:40 EDT ---
Also add "BuildRequires:  libtool"

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #14 from Fabian Affolter  2011-07-02 05:38:32 EDT ---
Thanks Roy.

For me it doesn't work on Fedora 15 with the latest svn checkout...
./configure: line 4450: `$as_echo "$as_me: WARNING: Libtool does not cope well
with whitespace in `pwd`" >&2;} ;;'

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #15 from Jon Burgess  2011-07-02 08:58:35 EDT ---
The configure error above seems to be triggered by this change in
osm2pgsql-configure.patch:

dnl Make sure we have libtool installed
-AM_PROG_LIBTOOL
+m4_pattern_allow(AM_PROG_LIBTOOL)

I guess this was done to workaround libtool not being available? Adding it as a
build requirement sounds like the correct thing to do instead.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #16 from Fabian Affolter  2011-09-10 18:23:15 EDT ---
This issue occurs with an unpatched configure.ac too.

As reference: http://trac.openstreetmap.org/ticket/3878

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

Mark  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Mark  2012-03-11 14:08:33 EDT ---
is anyone still working on this?

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #18 from Roy Rankin  2012-03-18 19:38:56 EDT ---
I do not see the issue that Fabian sees. With the last patch to
osm2pgsql-configure.patch removed and "BuildRequires:  libtool" the package
built for my both in mock and on a development system with required
dependencies.

I have done a pre-review and could quickly approve the package when Fabian
provides a package content that builds.

[Bug 626004] Review Request: osm2pgsql - Imports map data from OpenStreetMap to a PostgreSQL database

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=626004

--- Comment #19 from Fabian Affolter  2012-04-14 06:37:07 EDT ---
I reworked the patch to remove the gazetteer stuff. Now I able to build this
package again.

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/osm2pgsql-0.70.5-0.8.20120413svn....