[Bug 988866] New: Review Request:php-pecl-event - Provides interface to libevent library - package-review

List overview All Threads
Download

newer

[Bug 988866] New: Review Request:php-pecl-event - Provides interface to libevent library

older

[Bug 1077669] New: Review Request:...

[Bug 709328] Review Request:...

Red Hat Bugzilla

26 Jul 2013 26 Jul '13

10:15 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Bug ID: 988866 Summary: Review Request:php-pecl-event - Provides interface to libevent library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: https://raw.github.com/remicollet/remirepo/af464cdc477c529ee2e1b22c37d4b1438... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.1-2.remi.src.rpm Description: This is an extension to efficiently schedule I/O, time and signal based events using the best I/O notification mechanism available for specific platform. This is a port of libevent to the PHP infrastructure.

Version 1.0.0 introduces: * new OO API breaking backwards compatibility * support of libevent 2+ including HTTP, DNS, OpenSSL and the event listener.

Fedora Account System Username: remi

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RpM5Hziz8U&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

28 Jul 28 Jul

12:17 p.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #1 from Remi Collet fedora@famillecollet.com --- Update to 1.7.2

Spec: https://raw.github.com/remicollet/remirepo/1a411ba23962e14ca0cbcf11c9fefe138... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.2-1.remi.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dtd9liS6ig&a=cc_unsubscribe

Red Hat Bugzilla

19 Aug 19 Aug

12:32 p.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #2 from Remi Collet fedora@famillecollet.com --- Update to 1.7.5 https://github.com/remicollet/remirepo/commit/8a325a0f729e695738404f3f5fab49...

Spec: https://raw.github.com/remicollet/remirepo/8a325a0f729e695738404f3f5fab494f1... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.5-1.remi.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wVfOkUzdpx&a=cc_unsubscribe

Red Hat Bugzilla

8 Sep 8 Sep

9:35 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #3 from Remi Collet fedora@famillecollet.com --- Update to 1.7.6

Spec: https://raw.github.com/remicollet/remirepo/0b999cfa4b2bee100ea4386b8bb37b388... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.6-1.remi.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQyzHeCBn5&a=cc_unsubscribe

Red Hat Bugzilla

16 Sep 16 Sep

1:52 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Remi Collet fedora@famillecollet.com changed:

--- Comment #4 from Remi Collet fedora@famillecollet.com --- Update to 1.7.8

Spec: https://raw.github.com/remicollet/remirepo/c19341196dc90821aef6ada07a1919429... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.7.8-1.remi.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qySOYNn3ly&a=cc_unsubscribe

Red Hat Bugzilla

10 Jan 10 Jan

5:45 p.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Adam Williamson awilliam@redhat.com changed:

--- Comment #7 from Adam Williamson awilliam@redhat.com --- The spec linked in c#6 has a changelog indicating 1.8.1, but its Version field is still 1.8.0.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11 Jan 11 Jan

12:12 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #8 from Remi Collet fedora@famillecollet.com --- Oups... I think the correct one is

Spec: https://raw2.github.com/remicollet/remirepo/52e56482f197eae9301d0f67dacbb3f3... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.1-1.remi.src.rpm

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

12:44 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #9 from Remi Collet fedora@famillecollet.com --- Worth a cleanup https://github.com/remicollet/remirepo/commit/6c87aca9efeb4365bdb0a6370da1ea...

Spec: https://raw2.github.com/remicollet/remirepo/6c87aca9efeb4365bdb0a6370da1eaf7... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.8.1-2.remi.src.rpm

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

17 Jan 17 Jan

2:04 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #10 from Remi Collet fedora@famillecollet.com --- Update to 1.9.0 and minor cleanups https://github.com/remicollet/remirepo/commit/d08a936187097f50c0892e8942209b...

Spec: https://raw2.github.com/remicollet/remirepo/d08a936187097f50c0892e8942209b71... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.9.0-1.remi.src.rpm

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

2:07 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #11 from Remi Collet fedora@famillecollet.com --- Copr test build (Fedora and EPEL-7) in http://copr.fedoraproject.org/coprs/remi/morephp/monitor/

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

23 Mar 23 Mar

3:16 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #12 from Remi Collet fedora@famillecollet.com --- Update to 1.9.1 (compatible with PHP 5.6) https://github.com/remicollet/remirepo/commit/25993c2a8c8d100c17b750bcb792d9...

Spec: https://raw.githubusercontent.com/remicollet/remirepo/25993c2a8c8d100c17b750... Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-event-1.9.1-1.remi.src.rpm

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

3:18 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #13 from Remi Collet fedora@famillecollet.com --- @adam: as you are still assigned to this review, can you please proceed ?

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11:01 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #14 from Adam Williamson awilliam@redhat.com --- god, sorry, I completely forgot. I'll do it tomorrow.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

25 Mar 25 Mar

2:56 p.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Adam Williamson awilliam@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #15 from Adam Williamson awilliam@redhat.com --- [adamw@adam SRPMS]$ rpmlint php-pecl-event-1.9.1-1.remi.src.rpm php-pecl-event.src: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment php-pecl-event.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment php-pecl-event.src: E: unknown-key GPG#00f97f56 1 packages and 0 specfiles checked; 1 errors, 2 warnings. [adamw@adam x86_64]$ rpmlint php-pecl-event-* php-pecl-event.x86_64: W: spelling-error Summary(en_US) libevent -> lib event, lib-event, enlivenment php-pecl-event.x86_64: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Those are all fine, the GPG key obviously won't happen in the Fedora build system.

All MUST guidelines at https://fedoraproject.org/wiki/Packaging:ReviewGuidelines are fine. SHOULD guidelines look good too. Review is APPROVED.

Is it really correct to ship the tests as docs? Maybe a separate subpackage would be better? Just a thought, not blocking review.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

26 Mar 26 Mar

12:30 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #16 from Remi Collet fedora@famillecollet.com --- (In reply to Adam Williamson from comment #15)

...

Is it really correct to ship the tests as docs? Maybe a separate subpackage would be better? Just a thought, not blocking review.

I mostly consider "tests" as "examples" of using the library, so I think providing them as %doc makes sense.

I only provides tests for 2 reasons - examples - be consistent with "pecl list-files foo"

For some extensions, when a -devel subpackage exists (for headers) I also put examples and tests in this subpackage. Or when test suite is very large.

Thanks for the review.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

12:31 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #17 from Remi Collet fedora@famillecollet.com --- New Package SCM Request ======================= Package Name: php-pecl-event Short Description: Provides interface to libevent library Owners: remi Branches: f20 epel7 InitialCC:

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7:01 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7:01 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #18 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7:59 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7:59 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-pecl-event-1.9.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-pecl-event-1.9.1-1.fc20

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11:42 p.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #20 from Fedora Update System updates@fedoraproject.org --- php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 testing repository.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

4 Apr 4 Apr

4:39 a.m.

New subject: [Bug 988866] Review Request:php-pecl-event - Provides interface to libevent library

https://bugzilla.redhat.com/show_bug.cgi?id=988866

Fedora Update System updates@fedoraproject.org changed:

--- Comment #21 from Fedora Update System updates@fedoraproject.org --- php-pecl-event-1.9.1-1.fc20 has been pushed to the Fedora 20 stable repository.

-- You are receiving this mail because: You are always notified about changes to this product and component

4127

Age (days ago)

4379

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla