[Bug 477190] New: Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cas - core analysis system

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Summary: Review Request: cas - core analysis system
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://astokes.fedorapeople.org/cas.spec
SRPM URL: http://astokes.fedorapeople.org/cas-0.13-112.src.rpm
Description:
CAS provides a support engineer the ability to configure an environment for
core analysis quickly. All the hassles of configuring architecture specific
boxes, finding machines suitable for a particular core is now taken care of.

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Adam Stokes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Tom "spot" Callaway   2008-12-19 10:41:57 EDT ---
Okay, a few things to start with:

* Please don't use a source file for Version/Release. That's what the spec file
is for.
* You can't use "GPL" as a license tag, see: 
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
* Please put the full upstream path to your sources in your Source definitions.
* Run rpmlint on the packages (both SRPM and noarch RPM) and make sure you've
silenced the output.

When you've made these changes, be sure to increment Release and add a new
changelog entry describing the changes that you've made. Once that's done, post
a new SRPM and spec file and I'll pick up the review.

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #2 from Adam Stokes   2008-12-19 11:14:13 EDT ---
(In reply to comment #1)
> Okay, a few things to start with:
> Please don't use a source file for Version/Release. That's what the spec file
>
> is for.
> You can't use "GPL" as a license tag, see:
>
> https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL

Thanks, set to GPLv3
> Please put the full upstream path to your sources in your Source definitions.

Fixed
> Run rpmlint on the packages (both SRPM and noarch RPM) and make sure you've
>
> silenced the output.

[adam@conans cas]$ rpmlint -i ~/redhat/cas/noarch/cas-0.13-113.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[adam@conans cas]$ rpmlint -i ~/redhat/cas/cas-0.13-113.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> When you've made these changes, be sure to increment Release and add a new
> changelog entry describing the changes that you've made. Once that's done, post
> a new SRPM and spec file and I'll pick up the review.

Done
SRPM: http://astokes.fedorapeople.org/cas-0.13-113.src.rpm
SPEC: http://astokes.fedorapeople.org/cas.spec

thanks

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #3 from Tom "spot" Callaway   2008-12-19 11:51:54 EDT ---
Looking at the code, it looks like it is GPLv3+.

Why are the man pages separate from the upstream source? Seems like they'd be a
logical fit to go inside the tarball, or at the very least, uploaded to the
fedorahosted site. If you opt for the latter route, please provide full
upstream URLs.

Do you still need Source1? It doesn't seem to be used anymore.

You also don't need the Requires: python >= 2.4

Fedora's RPM will detect the python bits in the package and add a proper
versioned Requires on python(abi). For example, in rawhide, we get:

[spot@velociraptor ~]$ rpm -qp
/home/spot/rpmbuild/RPMS/noarch/cas-0.13-113.fc11.noarch.rpm --requires
/usr/bin/python  
config(cas) = 0.13-113.fc11
crash  
python >= 2.4
python(abi) = 2.6
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

Thus, your manual python Requires is unnecessary.

Also, the last sentence of the description doesn't make much sense. Can you fix
that up a bit? :)

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #4 from Adam Stokes   2008-12-29 06:34:27 EDT ---
(In reply to comment #3)
> Looking at the code, it looks like it is GPLv3+.

Thanks for the catch, this makes sense as I am not committed to v3 only
> Why are the man pages separate from the upstream source? Seems like they'd be a
> logical fit to go inside the tarball, or at the very least, uploaded to the
> fedorahosted site. If you opt for the latter route, please provide full
> upstream URLs.

Fixed
> Do you still need Source1? It doesn't seem to be used anymore.

Fixed
> You also don't need the Requires: python >= 2.4
>
> Fedora's RPM will detect the python bits in the package and add a proper
> versioned Requires on python(abi). For example, in rawhide, we get:
>
> [spot@velociraptor ~]$ rpm -qp
> /home/spot/rpmbuild/RPMS/noarch/cas-0.13-113.fc11.noarch.rpm --requires
> /usr/bin/python  
> config(cas) = 0.13-113.fc11
> crash  
> python >= 2.4
> python(abi) = 2.6
> rpmlib(CompressedFileNames) <= 3.0.4-1
> rpmlib(PartialHardlinkSets) <= 4.0.4-1
> rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>
> Thus, your manual python Requires is unnecessary.

Fixed
> Also, the last sentence of the description doesn't make much sense. Can you fix
> that up a bit? :)

Hopefully I cleared up the description, my writing skills are subpar :(

Thanks

http://astokes.fedorapeople.org/cas-0.13-114.src.rpm
http://astokes.fedorapeople.org/cas.spec

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Tom "spot" Callaway   2009-01-06 14:03:36 EDT ---
= Review =

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent (well, 99%)
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

One very minor item, you're using "${RPM_BUILD_ROOT}" and "$RPM_BUILD_ROOT" in
the spec. Pick one and use it consistently. You can make this change before you
commit to CVS.

APPROVED. I will sponsor you. Please follow the process here:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Adam Stokes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Adam Stokes   2009-01-07 07:56:51 EDT ---
New Package CVS Request
=======================
Package Name: cas
Short Description: automated core analysis tool 
Owners: astokes
Branches: F-9 F-10 EL-4 EL-5
InitialCC:

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-01-09 00:39:34 EDT ---
I don't see you in the packager group yet. Have you requested that yet?
See step 4 under here: 
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #8 from Adam Stokes   2009-01-12 06:20:53 EDT ---
Under the status is says 'unapproved' could this be why?

Thanks

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #9 from Adam Stokes   2009-01-12 06:41:00 EDT ---
Ok I re-applied, may I get approval now?

Thanks!

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #10 from Adam Stokes   2009-01-12 11:37:12 EDT ---
Ok thanks to spot I am now sponsored.

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #11 from Adam Stokes   2009-01-15 07:39:34 EDT ---
Hi, could i get a status update on this? Is there anything else needed from me?

Thanks!

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #12 from Tom "spot" Callaway   2009-01-15 10:59:37 EDT ---
Adam, please follow the process at this step (and read that document from top
to bottom, so you understand how things work).

http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and...

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Alex Lancaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Alex Lancaster   2009-01-22 04:37:21 EDT ---
(In reply to comment #12)
> Adam, please follow the process at this step (and read that document from top
> to bottom, so you understand how things work).
>
> http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and...

Adam you should always build in rawhide first before pushing updates to the
F-10 and F-9 branches:

http://fedoraproject.org/wiki/PackageMaintainers/Join#Request_Builds

This requirement should be made explicit in that doc.

In any case your push of cas has caused broken deps in rawhide because koji
"inherited" the F-10 build in rawhide (since there wasn't any F-11 cas build to
"override" it).  But that F-10 package of cas won't work on rawhide because
rawhide requires Python 2.6, not Python 2.5 (which is shipped on F-10):

Broken deps for i386
----------------------------------------------------------
 cas-0.13-118.fc10.noarch requires python(abi) = 0:2.5

http://koji.fedoraproject.org/mash/rawhide-20090122/logs/depcheck

So I took the liberty of rebuilding it for you:

https://koji.fedoraproject.org/koji/buildinfo?buildID=79757

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #14 from Adam Stokes   2009-01-22 09:33:35 EDT ---
Thank you, still getting used to the processes here and you're right the
documentation should perhaps mention to build in devel branch first.

Thanks again

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

--- Comment #15 from Tom "spot" Callaway   2009-01-22 10:02:59 EDT ---
(In reply to comment #13)
> Adam you should always build in rawhide first before pushing updates to the
> F-10 and F-9 branches:
>
> http://fedoraproject.org/wiki/PackageMaintainers/Join#Request_Builds
>
> This requirement should be made explicit in that doc.

I've added a warning to that section which should hopefully make that clear.

[Bug 477190] Review Request: cas - core analysis system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=477190

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #16 from Tom "spot" Callaway   2009-03-04 17:28:26 EDT ---
I see this in rawhide, closing out this bug.

Adam, in the future, make sure your Review Request bug is closed out when the
package is built.