https://bugzilla.redhat.com/show_bug.cgi?id=1539078
Bug ID: 1539078 Summary: Review Request: cjose - C library implementing the Javascript Object Signing and Encryption (JOSE) Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: puiterwijk@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://puiterwijk.fedorapeople.org//cjose.spec SRPM URL: http://puiterwijk.fedorapeople.org//cjose-0.5.1-1.fc27.src.rpm
Description: Implementation of JOSE for C/C++
https://bugzilla.redhat.com/show_bug.cgi?id=1539078
--- Comment #1 from Patrick Uiterwijk puiterwijk@redhat.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24469949
https://bugzilla.redhat.com/show_bug.cgi?id=1539078
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kevin@scrye.com Assignee|nobody@fedoraproject.org |kevin@scrye.com Flags| |fedora-review?
--- Comment #2 from Kevin Fenzi kevin@scrye.com --- I'll review this. Look for a review in a few...
https://bugzilla.redhat.com/show_bug.cgi?id=1539078
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- rpmlint says:
cjose-debugsource.x86_64: W: no-documentation cjose-devel.x86_64: W: only-non-binary-in-usr-lib cjose-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 4 warnings.
All of which can be ignored.
The "gitrev" in the source0 url needs to be %{version} instead. You can fix that on import.
License is ok and good.
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1539078
--- Comment #4 from Patrick Uiterwijk puiterwijk@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cjose
package-review@lists.fedoraproject.org