https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Bug ID: 1917266 Summary: Review Request: qt6 - Qt6 meta package Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jgrulich@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm Description: Qt6 meta package Fedora Account System Username: jgrulich
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |qt6
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com ---
sed -i \ -e "s|@@QT5_CFLAGS@@|%{?qt6_cflags}|g" \ -e "s|@@QT5_CXXFLAGS@@|%{?qt6_cxxflags}|g" \ -e "s|@@QT5_RPM_LD_FLAGS@@|%{?qt6_rpm_ld_flags}|g" \ -e "s|@@QT5_RPM_OPT_FLAGS@@|%{?qt6_rpm_opt_flags}|g" \ -e "s|@@QMAKE@@|%{_prefix}/%%{_lib}/qt6/bin/qmake|g" \ -e "s|@@QMAKE_QT5_WRAPPER@@|%{_bindir}/qmake-qt6.sh|g" \
Shouldn't these use QT6 instead of QT5?
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- You can also replace "%{_rpmconfigdir}/macros.d" with "%{_rpmmacrodir}" in the spec...
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997 (kde-reviews) |1917559 (qt6-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1917559 [Bug 1917559] Qt6-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
--- Comment #4 from Jan Grulich jgrulich@redhat.com --- Updated package:
Spec URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6/qt6/qt6-6.0.0-1.fc33.src.rpm Description: Qt6 meta package Fedora Account System Username: jgrulich
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package is named correctly * Package follows proper conventions for Qt packages * Package builds and installs (when everything else is available...) * No serious issues from rpmlint
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-01-22 16:12:40
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2196189
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2196189 [Bug 2196189] Review Request: qt6-qtlocation - Location Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1917266
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2196189 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2196189 [Bug 2196189] Review Request: qt6-qtlocation - Location Libraries
package-review@lists.fedoraproject.org