Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
Summary: Review Request: dwarves - DWARF Tools Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: acme@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://oops.ghostprotocols.net:81/acme/dwarves/rpm/dwarves.spec SRPM URL: http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/dwarves-0-16.src.rp... Description: dwarves is a set of tools that use the DWARF debugging information inserted in ELF binaries by compilers such as GCC , used by well known debuggers such as GDB, and more recent ones such as systemtap.
Utilities in the dwarves suite include pahole, that can be used to find alignment holes in structs and classes in languages such as C, C++, but not limited to these, and other information such as CPU cacheline alignment, helping pack those structures to achieve more cache hits, codiff, a diff like tool to compare the effects changes in source code generate on the resulting binaries, pfunct, that can be used to find all sorts of information about functions, inlines, decisions made by the compiler about inlining, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-04-02 10:42 EST ------- new SRPM: http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/dwarves-0-17.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-04-04 19:22 EST ------- New Release:
SRPM: http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/dwarves-0-18.src.rp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-04-25 16:14 EST ------- When somebody steps up to review this package, please contact me about making a new release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From wolfy@nobugconsulting.ro 2007-04-25 19:24 EST ------- Just a quick check (NOT official review), to fix some things which are obviously wrong:
- Source 0 is not downloadable (pahole-0.tar.bz2). -->please provide a means to verify that the included source is identical to upstreaml in particular, Source0 should be the full URL to the source or a description on how can the source be downloaded (for instance from svn or cvs) - wrong BuildRoot; please see Packaging/Guidelines#BuildRoot in the wiki - several packages are included by default in the buildroot and need not to be included: gcc, make, binutils, glibc-devel; please see Packaging/Guidelines#Exceptions in the wiki - make does not honor SMP flags. If it doesn't build with it, please add a comment; please see Packaging/Guidelines#parallelmake in the wiki - make does not honor RPM_OPT_FLAGS; I suggest taking a look at http://fedoraproject.org/wiki/PackagingDrafts/cmake - cosmetical change: would be nice if the rm -f line in %install and %clean would use the same -r or -R flag - rpmlint on the generated binary gives lots of warnings/errors: rpmlint of dwarves: W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_jprobe.c W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_jprobe.c E: dwarves script-without-shebang /usr/lib64/ctracer/Makefile W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_relay.h W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_relay.h W: dwarves devel-file-in-non-devel-package /usr/lib64/ctracer/ctracer_relay.c W: dwarves spurious-executable-perm /usr/lib64/ctracer/ctracer_relay.c W: dwarves non-standard-group Base W: dwarves no-version-in-last-changelog E: dwarves only-non-binary-in-usr-lib
rpmlint of dwarves-debuginfo: W: dwarves-debuginfo no-version-in-last-changelog rpmlint of libdwarves-devel: W: libdwarves-devel no-documentation W: libdwarves-devel no-dependency-on libdwarves W: libdwarves-devel non-standard-group Development W: libdwarves-devel no-version-in-last-changelog
rpmlint of libdwarves1: W: libdwarves1 no-documentation E: libdwarves1 library-without-ldconfig-postin /usr/lib64/libdwarves.so.1.0.0 E: libdwarves1 library-without-ldconfig-postun /usr/lib64/libdwarves.so.1.0.0 W: libdwarves1 non-standard-group Libraries W: libdwarves1 no-version-in-last-changelog
- wrong permissions of files: all files --including .c, .h, .py? in package dwarves-0-18.x86_64.rpm have exec bit set (755 instead of 644) - same goes for the files in the debug package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-05-11 15:13 EST ------- http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/ is being kept frequently updated with git snapshots. I've addressed most of the above problems. Now waiting for a new round of review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ajackson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
------- Additional Comments From ajackson@redhat.com 2007-05-11 20:49 EST ------- Taking for review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ajackson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |ajackson@redhat.com
------- Additional Comments From ajackson@redhat.com 2007-05-11 22:41 EST ------- As of 0-24:
% rpmlint i386/*.rpm W: dwarves no-version-in-last-changelog E: dwarves only-non-binary-in-usr-lib W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_relay.c W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_relay.h W: dwarves devel-file-in-non-devel-package /usr/lib/ctracer/ctracer_jprobe.c W: dwarves-debuginfo no-version-in-last-changelog W: libdwarves1 no-version-in-last-changelog W: libdwarves1 no-documentation W: libdwarves1-devel no-version-in-last-changelog
The one error is unpleasant. Any reason why that stuff's not in /usr/share? systemtap has similar code in its directories in /usr/share, so even though it technically violates one of the MUSTS in the review guidelines I think there's a good case for it.
Also, if the SRPM is intended to be the preferred distribution format, then you need to note that in a comment above Source0.
Otherwise passes all MUSTS as far as I can see.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-05-13 19:30 EST ------- If the preferred place is /usr/share, then I'll change it. I guess I can also cut a 1.0 version and put it in my kernel.org area and refer to it in the Source: tag. Will do that and report here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-05-22 12:28 EST ------- [acme@filo pahole]$ rpmlint rpm/RPMS/i386/* W: dwarves devel-file-in-non-devel-package /usr/share/dwarves/runtime/ctracer_relay.c W: dwarves devel-file-in-non-devel-package /usr/share/dwarves/runtime/ctracer_jprobe.c W: dwarves devel-file-in-non-devel-package /usr/share/dwarves/runtime/ctracer_relay.h W: libdwarves1 no-documentation [acme@filo pahole]$
Now I'm doing the last tests and will report soon when I have everything ready.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-05-22 12:58 EST ------- OK, new spec file at:
http://oops.ghostprotocols.net:81/acme/dwarves/rpm/dwarves.spec
New src.rpm at:
http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/dwarves-1.0-1.src.r...
And the 1.0 tarball is at:
http://userweb.kernel.org/~acme/dwarves-1.0.tar.bz2
Please let me know if there is still any problems.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ajackson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From ajackson@redhat.com 2007-05-23 17:53 EST ------- Looks good to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-05-23 23:37 EST ------- OK, so what is the next step?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(fedora-package- | |review@redhat.com)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From tibbs@math.uh.edu 2007-05-25 13:34 EST ------- I'm not sure what the point of setting needinfo to a mailing list is, but I can give you some references.
First, were you sponsored in the account system? (Even RH employees need this.) I don't see your address as the owner of any existing Fedora packages. If not, you'll need sponsorship before you can continue.
Setting aside the issue of sponsorship, you are at step 8 of http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
So the next step would be to make a CVS request as detailed in http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ajackson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED AssignedTo|ajackson@redhat.com |nobody@fedoraproject.org Flag|needinfo?(fedora-package- | |review@redhat.com) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ruben@rubenkerkhof.com
------- Additional Comments From ruben@rubenkerkhof.com 2007-06-17 03:43 EST ------- I can't fetch http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SRPMS/dwarves-1.0-1.src.r... (connection refused)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-06-17 10:15 EST ------- Should be OK now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234667
------- Additional Comments From ruben@rubenkerkhof.com 2007-06-17 11:39 EST ------- Ah, thanks
Just a few comments:
- Source0 line is wrong: Source: http://http://userweb.kernel.org/~acme/dwarves/%%7Bname%7D-%%7Bversion%7D.ta... - There are some new packaging guidelines (and macros) for cmake: http://fedoraproject.org/wiki/Packaging/cmake, can you please have a look at those?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora Version|devel |rawhide
------- Additional Comments From acme@redhat.com 2007-12-09 18:11 EST ------- Source0 line fixed, cmake packaging guidelines followed. Will try getting the CVS request step done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From acme@redhat.com 2007-12-09 18:17 EST ------- New Package CVS Request ======================= Package Name: dwarves Short Description: DWARF tools Owners: acme Branches: F-8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com Flag|fedora-cvs? |fedora-cvs-
------- Additional Comments From kevin@tummy.com 2007-12-10 11:52 EST ------- I don't see your account in the cvsextras group... have you been sponsored?
Might take a look at: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
Do you have any other packages to submit, and/or can you do some pre-reviewing of other package submissions?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-12-10 13:11 EST ------- No I haven't been sponsored, reading that URL. No, I don't have any other package to submit. Looking for some packages to pre-review now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
------- Additional Comments From acme@redhat.com 2007-12-12 11:57 EST ------- Latest specfile is at:
http://oops.ghostprotocols.net:81/acme/dwarves/rpm/SPECS/dwarves.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs- |fedora-cvs?
------- Additional Comments From acme@redhat.com 2008-01-05 15:48 EST ------- New Package CVS Request ======================= Package Name: dwarves Short Description: DWARF tools Owners: acme Branches: F-8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-01-05 16:45 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |acme@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dwarves - DWARF Tools
https://bugzilla.redhat.com/show_bug.cgi?id=234667
acme@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
Jon Stanley jonstanley@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonstanley@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #25 from Jon Stanley jonstanley@gmail.com 2011-02-28 12:11:17 EST --- Package Change Request ====================== Package Name: dwarves New Branches: EL-5 EL-6 Owners: jstanley InitialCC: acme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
--- Comment #26 from Jason Tibbitts tibbs@math.uh.edu 2011-02-28 13:26:55 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
--- Comment #27 from Fedora Update System updates@fedoraproject.org 2011-02-28 16:13:48 EST --- Package dwarves-1.9-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dwarves-1.9-2.el6' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/dwarves-1.9-2.el6 then log in and leave karma (feedback).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
--- Comment #28 from Fedora Update System updates@fedoraproject.org 2011-03-17 13:04:28 EDT --- dwarves-1.9-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |dwarves-1.9-2.el6 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
--- Comment #29 from Fedora Update System updates@fedoraproject.org 2011-03-17 15:56:43 EDT --- dwarves-1.9-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/dwarves-1.9-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
--- Comment #30 from Fedora Update System updates@fedoraproject.org 2011-07-12 11:01:37 EDT --- dwarves-1.9-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=234667
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|dwarves-1.9-2.el6 |dwarves-1.9-2.el5
package-review@lists.fedoraproject.org