https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Bug ID: 1180794 Summary: Review Request: nodejs-isstream - Determine if an object is a Stream Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pnemade@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-isstream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-isstream-0.1.1-1.f...
Description: Determine if an object is a Stream
Fedora Account System Username: pnemade
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews), | |1178786
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1178786 [Bug 1178786] nodejs-got-2.3.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |nodejs-isstream - Determine |nodejs-is-stream - Check if |if an object is a Stream |something is a Node.js | |stream
--- Comment #1 from Parag pnemade@redhat.com --- oops! I just realized I packaged wrong dependency isstream. Correct one is is-stream. Here is correct package for review.
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-is-stream.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-is-stream-1.0.1-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |piotr1212@gmail.com Assignee|nobody@fedoraproject.org |piotr1212@gmail.com Flags| |fedora-review+
--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find license in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1180794-nodejs-is- stream/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-is-stream-1.0.1-1.fc21.noarch.rpm nodejs-is-stream-1.0.1-1.fc21.src.rpm nodejs-is-stream.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-is-stream.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-is-stream.noarch: W: only-non-binary-in-usr-lib nodejs-is-stream.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-is-stream.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Requires -------- nodejs-is-stream (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-is-stream: nodejs-is-stream npm(is-stream)
Source checksums ---------------- https://github.com/sindresorhus/is-stream/archive/v1.0.1.tar.gz : CHECKSUM(SHA256) this package : e66b9461551bbc119c75e0a8ca60513821a4eb04511310bc6ede7f9a5d6ed8f5 CHECKSUM(SHA256) upstream package : e66b9461551bbc119c75e0a8ca60513821a4eb04511310bc6ede7f9a5d6ed8f5
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1180794 Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Parag pnemade@redhat.com --- Thanks for this package review.
New Package SCM Request ======================= Package Name: nodejs-is-stream Short Description: Check if something is a Node.js stream Upstream URL: https://github.com/sindresorhus/is-stream Owners: pnemade Branches: f20 f21 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
--- Comment #5 from Parag pnemade@redhat.com --- Built in rawhide, therefore closing.
https://bugzilla.redhat.com/show_bug.cgi?id=1180794
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-02-02 03:42:27
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla