Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
Summary: Review Request: ksynaptics - KDE configuration for synaptics module Product: Fedora Extras Version: devel Platform: All URL: http://www.cora.nwra.com/~orion/fedora/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: orion@cora.nwra.com QAContact: fedora-package-review@redhat.com
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/ksynaptics.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm Description:
KSynaptics (previously QSynaptics) is a Qt/KDE based configuration utility for the synaptics touchpad drivers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |rdieter@math.unl.edu OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From rdieter@math.unl.edu 2006-07-28 14:15 EST ------- upstream source checks out. c9c124ba59bbb898bfc73f2ab00e8006 ksynaptics-0.3.1.tar.bz2
A few initial comments:
1. Icons need scriptlets (See http://www.fedoraproject.org/wiki/ScriptletSnippets), something like:
%post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:
%postun
2. You don't really need: export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include anymore, the qt bug that this worked around is now fixed. touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:
Otherwise it looks good! Now, I'll try building and see how it works... (:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
------- Additional Comments From rdieter@math.unl.edu 2006-07-28 14:18 EST ------- oops, left %postun blank, it should have been the same:
%post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
------- Additional Comments From rdieter@math.unl.edu 2006-07-28 14:40 EST ------- I'd suggest replacing: desktop-file-install --vendor=fedora \ --add-category=Qt \ --add-category=KDE \ --add-category=Utility \ --add-category=X-Fedora \ --delete-original --dir %{buildroot}%{_datadir}/applications \ $RPM_BUILD_ROOT/%{_datadir}/applications/kde/%{name}.desktop
with simply: desktop-file-install \ --vendor="" --add-category=X-Fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde \ $RPM_BUILD_ROOT%{_datadir}/applications/kde/*.desktop
The vendor is clear already here (kde), and this is simply a KControl module, so there's no need to add those Categories.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
------- Additional Comments From orion@cora.nwra.com 2006-07-28 16:39 EST ------- spec and src.rpm updated. New srpm: http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm though you really only need the new spe.
- Add icon post/postun scripts - Add Requires: hicolor-icon-theme - Remove old QTDIR hack - Cleanup desktop file
Not sure if the hicolor-icon-theme requires is necessary, but I would think so since it installs into %{_datadir}/icons/hicolor/...
Thanks for the reviews Rex!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From rdieter@math.unl.edu 2006-07-28 18:29 EST ------- The Requires: hicolo-icon-theme probably isn't absolutely required, but I guess it doesn't hurt either.
approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Bug 200565 depends on bug 200555, which changed state.
Bug 200555 Summary: Review Request: libsynaptics - Synaptics touchpad driver library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200555
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
------- Additional Comments From orion@cora.nwra.com 2006-07-31 12:25 EST ------- Imported, built on devel, and added to owners.list.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565
Bug 200565 depends on bug 200555, which changed state.
Bug 200555 Summary: Review Request: libsynaptics - Synaptics touchpad driver library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200555
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ksynaptics - KDE configuration for synaptics module
https://bugzilla.redhat.com/show_bug.cgi?id=200565
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org