https://bugzilla.redhat.com/show_bug.cgi?id=1749755
Bug ID: 1749755 Summary: Review Request: rubygem-kramdown-syntax-coderay - Coderay syntax highlighting for kramdown Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-syntax-coderay... SRPM URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-syntax-coderay...
Description: kramdown-syntax-coderay uses coderay to highlight code blocks/spans.
Fedora Account System Username: decathorpe
COPR repo with working packages: https://copr.fedorainfracloud.org/coprs/decathorpe/jekyll4/monitor/
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1743745 Depends On| |1749749
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1743745 [Bug 1743745] rubygem-jekyll-4.0.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1749749 [Bug 1749749] kramdown version 2.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1749755 Bug 1749755 depends on bug 1749749, which changed state.
Bug 1749749 Summary: kramdown version 2.1.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1749749
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- 1. Review
* license okay (overall: MIT) * spec file clean * mock build okay for F-32 https://koji.fedoraproject.org/koji/taskinfo?taskID=37641779 * binary rpm installable on F-32 * rpmlint clean - src.rpm, binary rpms, installed rpm * at least "require"ing installed gem works ``` [mockbuild@6a90abd4ac174b7b845382de2995036e ~]$ ruby -e 'require "kramdown" ; require "kramdown-syntax-coderay"' ```
All okay.
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- ========================================================= This package (rubygem-kramdown-syntax-coderay) is APPROVED by mtasaka =========================================================
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- https://pagure.io/releng/fedora-scm-requests/issue/16686
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-kramdown-syntax-coderay
https://bugzilla.redhat.com/show_bug.cgi?id=1749755
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |rubygem-kramdown-syntax-cod | |eray-1.0.1-1.fc32 Resolution|--- |RAWHIDE Last Closed| |2019-09-13 13:28:26
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1377190
package-review@lists.fedoraproject.org